Fix WebCamTexture orientation on the wire#276
Merged
MaxHeimbrock merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
Two related issues caused remote participants to see local video at wrong orientations: 1. GetVideoRotation was mismapping cases: 0→_180, 180→_0, 270→_180. Android front cam in portrait reports videoRotationAngle == 270, so remotes saw the stream 90° off. Replaced with a straight passthrough across all four angles. 2. GetPixels32 returns rows bottom-up but WebRTC expects top-down, so the buffer was being sent vertically flipped. The previous "0→_180" mapping was masking this on desktop (180° rotation visually approximates a Y-flip on roughly-symmetric subjects), but it was never actually correct. Flip rows during the buffer copy. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two related bugs that caused remote participants to see local video at the wrong orientation:
WebCameraSource.GetVideoRotationwas mismapping cases (0→_180,180→_0,270→_180). Android front cam in portrait reportsvideoRotationAngle == 270, so remotes saw the stream 90° off. Replaced with a straight passthrough across all four angles.GetPixels32returns rows bottom-up but WebRTC expects top-down, so the buffer was being sent vertically flipped. The previous0→_180mapping was masking this on desktop (180° rotation visually approximates a Y-flip on roughly-symmetric subjects), but it was never actually correct. Flip rows during the buffer copy.Also includes a missing
.metafile forTaskYieldInstruction.cs.Test plan
_180hack to mask the Y-flip)🤖 Generated with Claude Code