Skip to content

Fix beam normalization#494

Merged
paganol merged 6 commits intomasterfrom
beam_normalization
Feb 11, 2026
Merged

Fix beam normalization#494
paganol merged 6 commits intomasterfrom
beam_normalization

Conversation

@paganol
Copy link
Member

@paganol paganol commented Feb 10, 2026

This pull request updates the polarization normalization in the Gaussian beam synthesis routine to match the convention used in the gauss_bl() function. As a result, the expected values in the corresponding unit tests have been updated to reflect the new normalization.

Beam synthesis normalization changes:

  • Added Challinor spin-2 normalization factor (exp(2*sigma^2)) for polarization modes in gauss_beam_to_alm to match the normalization used in gauss_bl().

Test updates for new normalization:

  • Updated expected values in test_gaussbeam_circular in test/test_beam_synthesis.py to reflect the new polarization normalization.
  • Updated expected values in test_gaussbeam_elliptical in test/test_beam_synthesis.py for consistency with the new normalization.

@paganol paganol added the bug Something isn't working label Feb 10, 2026
@paganol paganol linked an issue Feb 10, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  litebird_sim
  beam_synthesis.py
Project Total  

This report was generated by python-coverage-comment-action

@paganol
Copy link
Member Author

paganol commented Feb 10, 2026

Now the difference input VS convolved goes down to $10^{-19}$ K in polarization if we set epsilon=1e-13 in BeamConvolutionParameters. With the default, i.e. epsilon=1e-5, we reach $10^{-11}$ K. updated version of the notebook
Here an updated version of the notebook

@paganol
Copy link
Member Author

paganol commented Feb 10, 2026

@ziotom78, probably this fix could be added to the v0.16.x branch

@paganol paganol merged commit a56969f into master Feb 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polarization beam normalization mismatch

2 participants