Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Member
Author
|
Now the difference input VS convolved goes down to |
Member
Author
|
@ziotom78, probably this fix could be added to the v0.16.x branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the polarization normalization in the Gaussian beam synthesis routine to match the convention used in the
gauss_bl()function. As a result, the expected values in the corresponding unit tests have been updated to reflect the new normalization.Beam synthesis normalization changes:
exp(2*sigma^2)) for polarization modes ingauss_beam_to_almto match the normalization used ingauss_bl().Test updates for new normalization:
test_gaussbeam_circularintest/test_beam_synthesis.pyto reflect the new polarization normalization.test_gaussbeam_ellipticalintest/test_beam_synthesis.pyfor consistency with the new normalization.