Skip to content

replace naive unicode support with system-dependent in collapse-whitespa...#5

Open
vityok wants to merge 1 commit into
lisp:masterfrom
vityok:issue-4
Open

replace naive unicode support with system-dependent in collapse-whitespa...#5
vityok wants to merge 1 commit into
lisp:masterfrom
vityok:issue-4

Conversation

@vityok

@vityok vityok commented Jan 7, 2013

Copy link
Copy Markdown
Contributor

Replaces naive Unicode support in the collapse-whitespace function with the system-dependent whitespace handling.

Should fix Issue 4: #4

@lisp

lisp commented Jan 7, 2013

Copy link
Copy Markdown
Owner

good evening, vincent;

before we commit to this, the change reads as if it is to apply to
only a function which collapses white space.
please explain to me why the parser should collapse white space at
all? if white space appears in a literal term, it should be retained.

?

On 2013-01-07, at 20:49 , Victor wrote:

Replaces naive Unicode support in the collapse-whitespace function
with the system-dependent whitespace handling.

Should fix Issue 4: #4

You can merge this Pull Request by running git pull https://
github.com/vityok/de.setf.wilbur issue-4
Or view, comment on, or merge it at:

#5

Commit Summary
replace naive unicode support with system-dependent in collapse-
whitespace
File Changes
M src/nox/xml-util.lisp (34)
Patch Links:
https://github.com/lisp/de.setf.wilbur/pull/5.patch
https://github.com/lisp/de.setf.wilbur/pull/5.diff

@arademaker

Copy link
Copy Markdown

@lisp is this PR still open waiting for the answer to the question above? It is a good point, my initial thought was that it is related to XML processing cleaning up strings between XML nodes, not RDF. I will investigate. Unfortunately, only Ora Lassila will have the final answer.

@lisp

lisp commented Nov 26, 2018

Copy link
Copy Markdown
Owner

yes, it is still open waiting for an answer.

arademaker added a commit to arademaker/wilbur that referenced this pull request Dec 22, 2018
lisp#5. It still needs
investigation but the whole XML parsing will be replaced soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants