fix: arrange exclusive layer surfaces first#1004
Merged
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Refactored the removeExclusiveZone method to use std::ranges::find instead of std::find_if with a custom lambda. This change modernizes the code by leveraging C++20 ranges, making the intent clearer and reducing boilerplate. The new approach directly searches for the desired QObject* in the first element of each exclusive zone pair, improving code readability and maintainability.
Layer surfaces with a positive exclusive zone reserve output space that later layer surfaces should observe. Arranging all layer surfaces in a single pass can let non-exclusive surfaces compute geometry before the exclusive zone has been applied. Split layer surface arrangement into two passes: first arrange surfaces with exclusiveZone() > 0, then arrange surfaces with exclusiveZone() <= 0. This keeps exclusive-zone geometry updates ahead of non-exclusive layer placement while preserving the existing arrangeLayerSurface() behavior.
zccrs
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.