refactor: unify treeland logging category system#1001
Merged
zccrs merged 2 commits intoJun 18, 2026
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @deepin-wm, your pull request is larger than the review limit of 150000 diff characters
deepin-wm
force-pushed
the
refactor/treeland-logging-categories
branch
2 times, most recently
from
4029e4f to
7eac6db
Compare
1. Rename category variables from treelandXxx to lcTlXxx following Qt convention 2. Reorganize string IDs under treeland.* hierarchy (e.g. treeland.core, treeland.input) 3. Move scattered Q_LOGGING_CATEGORY definitions into treelandlogging.h/cpp 4. Migrate raw qDebug/qWarning/qCritical calls to categorized qCDebug/qCWarning/qCCritical 5. Remove duplicate category in gestures.cpp (qLcGestures merged into lcTlGestures) 6. Fix inconsistent string IDs (daemon.shortcut -> treeland.shortcut.daemon) Log: Unified treeland logging categories with consistent naming and hierarchy Influence: 1. Verify logging output still works correctly with existing category filters 2. Test that QT_LOGGING_RULES environment variable filters work as expected 3. Verify no regression in debug/warning/critical message output refactor: 统一 treeland 日志分类体系 1. 将分类变量名从 treelandXxx 重命名为 lcTlXxx，遵循 Qt 命名惯例 2. 重新组织字符串 ID 为 treeland.* 层级（如 treeland.core, treeland.input） 3. 将散落的 Q_LOGGING_CATEGORY 定义移入 treelandlogging.h/cpp 4. 将原始 qDebug/qWarning/qCritical 调用迁移为分类 qCDebug/qCWarning/qCCritical 5. 移除 gestures.cpp 中的重复分类（qLcGestures 合并至 lcTlGestures） 6. 修复不一致的字符串 ID（daemon.shortcut -> treeland.shortcut.daemon） Log: 统一 treeland 日志分类命名和层级体系 Influence: 1. 验证日志输出在现有分类过滤器下仍正常工作 2. 测试 QT_LOGGING_RULES 环境变量过滤功能 3. 验证 debug/warning/critical 消息输出无回归 Fixes: linuxdeepin#990
deepin-wm
force-pushed
the
refactor/treeland-logging-categories
branch
from
7eac6db to
3ac6977
Compare
|
TAG Bot New tag: 0.8.11 |
deepin-wm
force-pushed
the
refactor/treeland-logging-categories
branch
from
a72fea8 to
9cf1125
Compare
1. Rename category variables from treelandXxx to lcTlXxx following Qt convention 2. Reorganize string IDs under treeland.* hierarchy (e.g. treeland.core, treeland.input) 3. Move scattered Q_LOGGING_CATEGORY definitions into treelandlogging.h/cpp 4. Migrate raw qDebug/qWarning/qCritical calls to categorized qCDebug/qCWarning/qCCritical 5. Remove duplicate category in gestures.cpp (qLcGestures merged into lcTlGestures) 6. Fix inconsistent string IDs (daemon.shortcut -> treeland.shortcut.daemon) 7. Add local logging categories for standalone binaries: lcXwaylandHelper, lcSdSocket Log: Unified treeland logging categories with consistent naming and hierarchy Influence: 1. Verify logging output still works correctly with existing category filters 2. Test that QT_LOGGING_RULES environment variable filters work as expected 3. Verify no regression in debug/warning/critical message output 4. Test xwayland helper and systemd-socket helper logging output refactor: 统一 treeland 日志分类体系 1. 将分类变量名从 treelandXxx 重命名为 lcTlXxx，遵循 Qt 命名惯例 2. 重新组织字符串 ID 为 treeland.* 层级（如 treeland.core, treeland.input） 3. 将散落的 Q_LOGGING_CATEGORY 定义移入 treelandlogging.h/cpp 4. 将原始 qDebug/qWarning/qCritical 调用迁移为分类 qCDebug/qCWarning/qCCritical 5. 移除 gestures.cpp 中的重复分类（qLcGestures 合并至 lcTlGestures） 6. 修复不一致的字符串 ID（daemon.shortcut -> treeland.shortcut.daemon） 7. 为独立二进制文件添加本地日志分类：lcXwaylandHelper、lcSdSocket Log: 统一 treeland 日志分类命名和层级体系 Influence: 1. 验证日志输出在现有分类过滤器下仍正常工作 2. 测试 QT_LOGGING_RULES 环境变量过滤功能 3. 验证 debug/warning/critical 消息输出无回归 4. 测试 xwayland 辅助工具和 systemd-socket 辅助工具的日志输出 Fixes: linuxdeepin#990
deepin-wm
force-pushed
the
refactor/treeland-logging-categories
branch
from
9cf1125 to
75e1efc
Compare
zccrs
approved these changes
Jun 18, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-wm, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify treeland logging category system following Qt convention.
Changes
treelandXxxtolcTlXxxfollowing Qt conventiontreeland.*hierarchy (e.g.treeland.core,treeland.input)Q_LOGGING_CATEGORYdefinitions intotreelandlogging.h/cppqDebug/qWarning/qCriticalcalls to categorizedqCDebug/qCWarning/qCCriticalgestures.cpp(qLcGesturesmerged intolcTlGestures)daemon.shortcut->treeland.shortcut.daemon)Testing
QT_LOGGING_RULESenvironment variable filters work as expectedRelated: #990