fix: adapt to treeland wallpaper protocol changes#387
Merged
Conversation
1. Update treeland-protocols build dependency to require version > 0.5.8 2. This fixes compatibility with the broken wallpaper protocol interface 3. The protocol breaking change in treeland requires updated protocol headers Log: Fixed wallpaper display issue with treeland environment Influence: 1. Verify wallpaper displays correctly in treeland environment 2. Test wallpaper switching functionality 3. Ensure no regression in other desktop environments 4. Confirm build succeeds with new dependency version fix: 适配 treeland 壁纸协议变更 1. 将 treeland-protocols 构建依赖更新至 0.5.8 以上版本 2. 修复与损坏的壁纸协议接口的兼容性问题 3. treeland 协议的破坏性变更需要更新协议头文件 Log: 修复treeland环境下壁纸显示问题 Influence: 1. 验证treeland环境下壁纸是否正确显示 2. 测试壁纸切换功能 3. 确保其他桌面环境无回归问题 4. 确认使用新依赖版本构建成功
Contributor
|
Warning
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Debian packaging dependency on treeland-protocols to require a newer version compatible with the updated/breaking wallpaper protocol, ensuring builds use headers that match the treeland wallpaper interface changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If the wallpaper protocol change affects runtime behavior and not just code generation, consider whether the corresponding runtime dependency (not only Build-Depends) also needs its minimum version bumped in debian/control to avoid mismatched headers vs. library at install time.
- Double-check that the version constraint syntax you’re using for treeland-protocols in debian/control is valid for all targeted Debian/Ubuntu releases (e.g., using the correct comparison operator and package name as recognized by their archives).
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If the wallpaper protocol change affects runtime behavior and not just code generation, consider whether the corresponding runtime dependency (not only Build-Depends) also needs its minimum version bumped in debian/control to avoid mismatched headers vs. library at install time.
- Double-check that the version constraint syntax you’re using for treeland-protocols in debian/control is valid for all targeted Debian/Ubuntu releases (e.g., using the correct comparison operator and package name as recognized by their archives).Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 --- a/debian/control
+++ b/debian/control
@@ -11,7 +11,7 @@ Build-Depends: debhelper-compat (= 12),
librsvg2-dev,
libfreeimage-dev,
libraw-dev,
- treeland-protocols,
+ treeland-protocols (>>0.5.8),
extra-cmake-modules,
libdtkdata,
libdtkcore-dev <!nodtk5>, |
BLumia
approved these changes
Jun 16, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headers
Log: Fixed wallpaper display issue with treeland environment
Influence:
fix: 适配 treeland 壁纸协议变更
Log: 修复treeland环境下壁纸显示问题
Influence:
Summary by Sourcery
Build: