fix: keep notification close button hoverable at the edge#1636
fix: keep notification close button hoverable at the edge#1636robertkill wants to merge 1 commit into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @robertkill, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
robertkill
force-pushed
the
fix/bug-365963-notification-hover
branch
from
15da7e2 to
c10cf5b
Compare
deepin pr auto review★ 总体评分：100分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 ListView {
id: bubbleView
readonly property int bubbleContentWidth: 360
readonly property int closeButtonInputMargin: 12
readonly property int bubbleRightMargin: 10
width: bubbleContentWidth + closeButtonInputMargin + bubbleRightMargin
height: contentHeight
anchors {
right: parent.right
bottom: parent.bottom
rightMargin: 0
bottomMargin: 10
}
// ...
root.DLayerShellWindow.setInputRegionRect(
Math.ceil(bubbleView.x),
Math.ceil(bubbleView.y),
Math.ceil(bubbleView.width),
Math.ceil(Math.max(10, bubbleView.contentHeight))
) |
| Math.ceil(bubbleView.x), | ||
| Math.ceil(bubbleView.y), | ||
| Math.ceil(bubbleView.width), | ||
| Math.ceil(bubbleView.width), |
There was a problem hiding this comment.
已调整：input region 宽度改为直接使用 window/root 宽度。同时补充处理关闭按钮外露区域的 hover 状态，确保该区域能保持关闭按钮显示并调用 setHoveredId 阻止通知超时关闭；临时调试日志已清理，已在调试机复验。
|
TAG Bot New tag: 2.0.46 |
|
TAG Bot New tag: 2.0.47 |
1. Extend the notification bubble input area to cover the close button edge outside the notification card background 2. Keep the bubble delegate width aligned with the expanded input area while preserving the 360px notification content layout and right margin 3. Use the delegate hover state to keep the close button visible and block timeout closing while the pointer stays on the edge area Influence: 1. Test notification bubble hover on the notification body and close button edge 2. Verify the close button remains visible when hovering its top-right edge 3. Verify hovered notifications do not expire automatically 4. Verify notification position and stacking animation remain unchanged fix: 保持通知关闭按钮边缘区域悬停状态 1. 扩展通知气泡输入区域，覆盖通知卡片背景外的关闭按钮边缘区域 2. 保持delegate宽度与扩展后的输入区域一致，同时保留360px通知内容布局和右边距 3. 使用delegate悬停状态保持关闭按钮显示，并在指针位于边缘区域时阻止通知超时关闭 Influence: 1. 测试通知主体和关闭按钮边缘区域的悬停效果 2. 验证鼠标悬停在右上角关闭按钮边缘时关闭按钮持续显示 3. 验证悬停状态下通知不会自动超时消失 4. 验证通知显示位置和堆叠动画保持不变 PMS: BUG-365963
robertkill
force-pushed
the
fix/bug-365963-notification-hover
branch
from
c10cf5b to
ee59c2e
Compare
3 participants
Summary
Verification
export PATH="/usr/lib/icecc/bin:$PATH"andexport LD_LIBRARY_PATH="".PMS: BUG-365963