feat(dock): add app launch event reporting for taskbar icons#1606
feat(dock): add app launch event reporting for taskbar icons#1606Ivy233 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ivy233 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
35405ee to
0b79013
Compare
|
TAG Bot New tag: 2.0.43 |
2e0b988 to
31355d0
Compare
|
TAG Bot New tag: 2.0.44 |
|
TAG Bot New tag: 2.0.45 |
Use AM.Identify(pidfd) for precise per-window instance mapping, read X-linglong from desktop files, and query dpkg/linglong for package version info. Report the data via DDE EventLogger (event ID 1000610003). 使用 pidfd 精准匹配窗口与 AM 实例,从桌面文件读取玲珑包名, 通过 dpkg/玲珑查询包版本信息,并通过 DDE EventLogger 上报数据。 Log: 新增任务栏图标启动时长上报 PMS: TASK-389405
31355d0 to
80ec6eb
Compare
deepin pr auto review☀ ★ 总体评分:60分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/panels/dock/taskmanager/launchdurationreporter.cpp b/panels/dock/taskmanager/launchdurationreporter.cpp
index dc264bc1b..safe_version 100644
--- a/panels/dock/taskmanager/launchdurationreporter.cpp
+++ b/panels/dock/taskmanager/launchdurationreporter.cpp
@@ -154,7 +154,7 @@ QString queryDebVersion(const QString &desktopFilePath)
if (QFileInfo::exists(infoDir)) {
QProcess search;
search.start(QStringLiteral("grep"),
- {QStringLiteral("-rlFx"), QStringLiteral("--include=*.list"), desktopFilePath, infoDir});
+ {QStringLiteral("-rlFx"), QStringLiteral("--include=*.list"), QStringLiteral("--"), desktopFilePath, infoDir});
if (!search.waitForFinished(1000)) {
qCWarning(launchDurationReporter) << "[DockIconTiming] grep dpkg file list timeout for" << desktopFilePath;
return QString();
@@ -170,7 +170,7 @@ QString queryDebVersion(const QString &desktopFilePath)
} else {
QProcess search;
search.start(QStringLiteral("dpkg"),
- {QStringLiteral("-S"), desktopFilePath});
+ {QStringLiteral("-S"), QStringLiteral("--"), desktopFilePath});
if (!search.waitForFinished(2000)) {
qCWarning(launchDurationReporter) << "[DockIconTiming] dpkg -S timeout for" << desktopFilePath;
return QString();
@@ -188,7 +188,7 @@ QString queryDebVersion(const QString &desktopFilePath)
QProcess query;
query.start(QStringLiteral("dpkg-query"),
- {QStringLiteral("-W"), QStringLiteral("-f=${Version}"), packageName});
+ {QStringLiteral("-W"), QStringLiteral("-f=${Version}"), QStringLiteral("--"), packageName});
if (!query.waitForFinished(1000)) {
qCWarning(launchDurationReporter) << "[DockIconTiming] dpkg-query timeout for" << packageName;
return QString(); |
|
TAG Bot New tag: 2.0.46 |
Log: Report app launch events when taskbar icons appear for analytics
Influence:
feat(dock): 添加任务栏图标出现时的应用启动事件上报
Log: 任务栏图标出现时上报应用启动事件用于分析
Influence:
PMS: TASK-389405