chore: remove unused network connection sync interfaces#1147
Merged
Conversation
The NetworkGetConnections and NetworkSetConnections D-Bus methods were deprecated and no longer used by any caller. This commit removes the entire network connection sync implementation including: 1. The D-Bus method registrations for NetworkGetConnections and NetworkSetConnections 2. The network.go file containing the sync logic for reading/writing NetworkManager connection files 3. The associated test file network_test.go 4. The network connection data structures and utilities in common/dsync/ network.go 5. The reloadConnections helper function and related NetworkManager D- Bus constants from utils.go These interfaces were originally used by the network synchronization feature between the system daemon and deepin-sync tool, which has been moved to other components. Removing unused code reduces maintenance burden and binary size. Influence: 1. Verify the system daemon still starts and exports D-Bus methods correctly 2. Run unit tests to ensure no compilation or test failures 3. Confirm no other components or tools depend on these removed interfaces 4. Verify system network management functionality is unaffected chore: 删除未使用的网络连接同步接口 NetworkGetConnections和NetworkSetConnections这两个D-Bus方法已被弃用且没 有任何调用者。本次提交移除了整个网络连接同步的实现,包括: 1. NetworkGetConnections和NetworkSetConnections的D-Bus方法注册 2. network.go文件中读写NetworkManager连接文件的同步逻辑 3. 相关的测试文件network_test.go 4. common/dsync/network.go中的网络连接数据结构和工具函数 5. utils.go中的reloadConnections辅助函数及相关NetworkManager D-Bus常量 这些接口最初用于系统守护进程和deepin-sync工具之间的网络同步功能,现已迁 移到其他组件。删除未使用的代码可以减少维护负担和二进制大小。 Influence: 1. 验证系统守护进程仍能正常启动并导出D-Bus方法 2. 运行单元测试,确保编译和测试无失败 3. 确认没有其他组件或工具依赖这些已删除的接口 4. 验证系统网络管理功能不受影响 PMS: BUG-364749 BUG-364745 Change-Id: I6e12c694f177d96eb1fb74e902904d128051bc9a
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR removes the deprecated network connection synchronization feature from dde-system-daemon, including D-Bus methods, NetworkManager sync helpers, and associated data structures/tests, leaving only the remaining daemon and backlight helper logic intact. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
caixr23
approved these changes
Jun 16, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: caixr23, xionglinlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NetworkGetConnections and NetworkSetConnections D-Bus methods were deprecated and no longer used by any caller. This commit removes the entire network connection sync implementation including:
These interfaces were originally used by the network synchronization feature between the system daemon and deepin-sync tool, which has been moved to other components. Removing unused code reduces maintenance burden and binary size.
Influence:
chore: 删除未使用的网络连接同步接口
NetworkGetConnections和NetworkSetConnections这两个D-Bus方法已被弃用且没 有任何调用者。本次提交移除了整个网络连接同步的实现,包括:
这些接口最初用于系统守护进程和deepin-sync工具之间的网络同步功能,现已迁
移到其他组件。删除未使用的代码可以减少维护负担和二进制大小。
Influence:
PMS: BUG-364749 BUG-364745
Change-Id: I6e12c694f177d96eb1fb74e902904d128051bc9a
Summary by Sourcery
Remove deprecated network connection synchronization interfaces and related NetworkManager integration from the system daemon.
Enhancements: