bugfix: make sure busybox's fdisk output parsing is not positional, support qemu and fix debug output#1884
Draft
tlaurion wants to merge 1 commit intolinuxboot:masterfrom
Draft
Conversation
…upport qemu and fix debug output Signed-off-by: Thierry Laurion <[email protected]>
| return 0 | ||
|
|
||
| # Check for partition entries in the fdisk output | ||
| if echo "$DISK_DATA" | grep -q "^/dev"; then |
Collaborator
There was a problem hiding this comment.
IIRC, this will break on a device directly formatted FAT32 without being partitioned. (That's what I wrote above - in that case, fdisk prints out a partition table but with no partitions. The FAT32 "volume boot record" is essentially the same as a master boot record.)
Instead I'd suggest looking for the heading, then checking if there are any partition lines following it. awk would be a good fit for this.
If you don't beat me to it, I can suggest a solution here after I get through my post-holidays inbox 😁
Collaborator
Author
|
I couldn't replicate under qemu with resized disk (mbr though) Marking this PR as draft. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mitigation for #1883