docker_* helpers: pass usb host controllers to docker only if usb devices are connected, unify, bugfixes#1856
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom Nov 21, 2024
Conversation
…ices are connected, unify, bugfixes Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Collaborator
Author
|
extends #1855 |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the handling of Docker images and the management of USB devices in the
docker_latest.sh,docker_local_dev.sh, anddocker_repro.shscripts. The most important changes include setting Docker image variables, enhancing thekill_usb_processesfunction, and modifying the Docker run commands to handle USB device access more intelligently.Docker Image Handling:
DOCKER_IMAGEvariable to store the Docker image name indocker_latest.shanddocker_local_dev.sh. This improves consistency and makes it easier to update the image name in the future. [1] [2]USB Device Management:
kill_usb_processesfunction to check ifscdaemonorpcscdprocesses are using USB devices before attempting to kill them. This prevents unnecessary error messages and ensures only relevant processes are targeted. [1] [2] [3]Docker Run Command: