Skip to content

Conversation

@grevanak-akamai
Copy link
Contributor

@grevanak-akamai grevanak-akamai commented Jan 2, 2026

Description 📝

As part of this PR, logic to remove devices from a firewall is updated to allow removal of linode interface from it.

Changes 🔄

  • In FirewallDeviceTable.tsx file, logic to derive isLinodeUpdatable is fixed for removal linode interfaces as well.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

NA

Preview 📷

Before After
Screenshot 2026-01-02 at 12 40 47 PM Screenshot 2026-01-02 at 12 40 11 PM

How to test 🧪

Prerequisites

  • Ensure linode interfaces feature is enabled
  • Go to firewalls/{firewall_id}/linodes page

Reproduction steps

  • Currently in prod and test environments, under linodes tab in devices table of firewall details page, Remove button is disabled for linode interfaces.

Verification steps

  • Ensure remove button is enabled for linode interfaces as well
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 870 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing870 Passing11 Skipped47m 19s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants