Fix AddNet5Support script to not update C# to C++ translator paths#32
Open
Fix AddNet5Support script to not update C# to C++ translator paths#32
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #5
The script was using overly broad regex patterns that replaced all occurrences of netcoreapp3.0 with netcoreapp3.1, including CSharpToCppTranslator paths. Fixed by making the regex patterns more specific to only target: - <TargetFramework> XML elements - Target frameworks within <TargetFrameworks> elements (handling semicolon separators) This preserves CSharpToCppTranslator executable paths and Condition attributes while still properly updating project target frameworks as intended. Fixes #5 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netcoreapp3.0, including CSharpToCppTranslator executable paths<TargetFramework>and<TargetFrameworks>XML elementsProblem
The original script used this pattern:
's/netcoreapp3\.0/netcoreapp3.1/g'This would incorrectly change:
To:
Solution
Now uses specific patterns:
This preserves CSharpToCppTranslator paths while properly updating project target frameworks.
Test plan
🤖 Generated with Claude Code
Resolves #5