Draft
Conversation
611bfe1 to
a2045d4
Compare
f51b0b2 to
b95f9ca
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
- Coverage 92.69% 88.65% -4.04%
==========================================
Files 8 11 +3
Lines 1465 1737 +272
==========================================
+ Hits 1358 1540 +182
- Misses 107 197 +90
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
TODO:
napi-rs shipped with a built in github pipelines to produce and publish platform specific binaries. However it doesn't created for monorepos, it assumes that the whole repo holds only on package. So manual work still needed.
I want to have lingui plugin and extractor close together so they always in sync, so we at minumum should be able to release these 2 from a monorepo.
At maximum it would be good to also publish rust crates, so other developers may use them in their tooling if they want.