copytool: support native Windows OpenSSH - #5299
Open
jandubois wants to merge 1 commit into
Open
Conversation
This was referenced Jul 21, 2026
jandubois
force-pushed
the
copytool-native-windows-openssh
branch
from
July 26, 2026 07:06
460484a to
20d168a
Compare
jandubois
force-pushed
the
copytool-native-windows-openssh
branch
from
July 26, 2026 07:18
20d168a to
c02e44a
Compare
This was referenced Jul 26, 2026
jandubois
force-pushed
the
copytool-native-windows-openssh
branch
2 times, most recently
from
July 27, 2026 06:36
5c631f4 to
a5a9836
Compare
On Windows, `limactl copy` converted host paths to the Cygwin/MSYS form no matter which tool would consume them, and it passed ControlMaster options unconditionally. Native OpenSSH cannot use that path form and has no multiplexing, so scp failed with "getsockname failed". The two backends need different path forms. scp takes whatever its own toolchain uses, while rsync on Windows is always Cygwin-based and reads a drive letter as a hostspec. So every path now takes the form of the binary that reads it, operands and ssh options alike, because scp hands its options to the ssh beside itself while rsync hands them to the ssh it names. Both backends now skip multiplexing on Windows, so they stop building a control socket path they never use. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
copytool-native-windows-openssh
branch
from
July 27, 2026 06:41
a5a9836 to
628fa44
Compare
Member
Author
jandubois
marked this pull request as ready for review
July 27, 2026 07:47
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
limactl copyconverted host paths to the Cygwin/MSYS form no matter which tool would consume them, and it passed ControlMaster options unconditionally. Native OpenSSH cannot use that path form and has no multiplexing, so scp failed withgetsockname failed.The two backends need different path forms, so every path now takes the form of the binary that reads it. Both also skip multiplexing on Windows.
Part of the native Windows OpenSSH series. It can merge in any order, except that #5337 appends to the same test file, so whichever lands second needs a trivial rebase there. The Windows jobs exercise only the Cygwin scp path, because the runners carry no rsync of their own. That coverage and validation on a plain Windows host both arrive with the CI jobs in #5342.
Assisted-by: Claude Opus 5