Skip to content

Expose with-all channel funding variants - #259

Merged
benthecarman merged 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-08-with-all
Aug 19, 2026
Merged

Expose with-all channel funding variants#259
benthecarman merged 2 commits into
lightningdevkit:mainfrom
tankyleo:2026-08-with-all

Conversation

@tankyleo

@tankyleo tankyleo commented Aug 19, 2026

Copy link
Copy Markdown
Contributor 
    Expose with-all channel funding variants

    Accept 'all' in the CLI and MCP funding amount fields for channel
    opening and splice-in. Represent each choice in gRPC with a typed
    protobuf oneof.

    Dispatch announced, unannounced, and zero-reserve channel opens plus
    splice-in to the corresponding ldk-node with-all methods.

    Co-Authored-By: HAL 9000

@ldk-reviews-bot

ldk-reviews-bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo
tankyleo requested a review from benthecarman August 19, 2026 05:41
benthecarman
benthecarman requested changes Aug 19, 2026
View reviewed changes
Comment thread ldk-server-mcp/src/tools/handlers.rs Outdated
Comment thread ldk-server-mcp/src/tools/handlers.rs Outdated
Comment thread ldk-server/src/api/open_channel.rs Outdated
Comment thread ldk-server-cli/src/main.rs
@tankyleo
tankyleo force-pushed the 2026-08-with-all branch 3 times, most recently from e9f07c9 to e280602 Compare August 19, 2026 07:23
@tankyleo
tankyleo requested a review from benthecarman August 19, 2026 07:26
@tankyleo
Expose with-all channel funding variants
4c73b78 
Accept "all" in the CLI and MCP funding amount fields for channel
opening and splice-in. Represent each choice in a typed protobuf
oneof.

Dispatch announced, unannounced, and zero-reserve channel opens and
splice-in to the corresponding ldk-node with-all methods.

AI-assisted-by: OpenAI Codex
@tankyleo
Rework on-chain send amounts
e3bc325 
Replace the send-all boolean with the typed exact-or-all protobuf
oneof used by channel funding. Accept "all" as the positional CLI and
MCP amount while preserving exact sends.

AI-assisted-by: OpenAI Codex
benthecarman
benthecarman approved these changes Aug 19, 2026
View reviewed changes

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@benthecarman
benthecarman merged commit 7f3276a into lightningdevkit:main Aug 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tankyleo @ldk-reviews-bot @benthecarman