webOS: BT keyboard text caret vs Magic Remote OSK navigation - #19275
Merged
LibretroAdmin merged 1 commit intoJul 29, 2026
Conversation
After a physical typing key, arrows move the caret (↑/↓ as home/end) and Enter/numpad Enter save the line. Remote arrows/OK/digits stay on the OSK grid so number buttons do not flip into caret mode.
Contributor
|
Tested works, thanks 👍 |
Contributor
|
Please be more careful in the future with this webOS specific code that touches core SDL files in RetroArch. sdl_input.c is a very generic SDL input driver that gets used by tons of other platforms and devices. Introducing highly specific webOS code like this without proper ifdef guards around it could be a very big compatibility issue |
LibretroAdmin
added a commit
that referenced
this pull request
Jul 29, 2026
The Enter/numpad-Enter character override added in #19275 was placed outside the WEBOS guard, so it ran on every SDL platform. On the common path it is at best a no-op and at worst a regression: * With no modifiers held, input_keymaps_translate_rk_to_ascii() already returns '\r' for RETROK_RETURN and '\n' for RETROK_KP_ENTER, and the line editor saves on either, so the override changed nothing. * With Alt/Ctrl/Meta held, the translation deliberately returns no character so that hotkey chords cannot type. The unconditional override bypassed that: Alt+Enter (e.g. the fullscreen toggle chord) with a menu text field open would submit the half-typed line, and cores received a spurious '\r' character on chorded Enter. Move the override under #ifdef WEBOS next to the existing numpad-Enter phys-kbd latch, restoring pre-#19275 character semantics on all other SDL platforms while keeping the webOS behaviour intact.
Contributor
Author
|
it looked like common issue, this is why adopted it everywhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?/ a square glyph)Test plan