add meson.build to define pyprima sources for downstream vendoring#266
Open
lucascolley wants to merge 1 commit intolibprima:mainfrom
Open
add meson.build to define pyprima sources for downstream vendoring#266lucascolley wants to merge 1 commit intolibprima:mainfrom
meson.build to define pyprima sources for downstream vendoring#266lucascolley wants to merge 1 commit intolibprima:mainfrom
Conversation
Member
|
Thank you @lucascolley . @nbelakovski Could you take a look? |
Contributor
|
Thanks for the PR @lucascolley. I'll take a look at it in more detail later this week, but my first thoughts are a) it's probably fine, and b) I'm in the middle of some pretty heavy refactoring of various files and folders related to python bindings and pyprima, so I would want to wait to do this PR until that's completed (hopefully within a week or two). |
Author
|
No rush, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nbelakovski @zaikunzhang, currently in SciPy we are maintaining a simple meson.build file which wraps around the pyprima source to integrate it with our meson build system. This PR moves that file into this repo, which will allow us to wrap pyprima directly, and enable other projects which use Meson to easily do the same.
Are you happy having the file in this repo? There is no obligation to keep it up to date, I'm sure SciPy maintainers can send a PR if needed. It does make sense to have the list of sources maintained in the same repo as the sources IMO.