test: run unit tests for each built wheel - #1432
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
in an assertion
only affects ppc64le linux platform
|
I had to fix an assertion that was too broad for the test requirements. I also have to skip testing wheels built when Otherwise, the tests are running fine on native built wheels (x86, x64, arm). 🎉 |
|
This is cool. Now as you said we could replace the tests workflow, and run this instead.
What do you think? Will you make a new PR? |
Sure. That sounds rather easy enough. BTW, What's the procedure for updating the CHANGELOG? Is that dependent on maintainers? Is there interest in auto-creating a GitHub release (when a tag is pushed) with auto-generated notes? |
|
I maintain the changelog, so far it's not much of a burden, so I didn't bother with automating it. |
|
Yeah, automating the changelog is best done with conventional-commit messages (the format I've been using for all my PR titles). It would be easy to add a step to wheels.yml - name: Create GitHub Release
env:
GITHUB_TOKEN: ${{ github.token }}
TAG: ${{ github.ref_name }}
REPO: ${{ github.repository }}
# https://cli.github.com/manual/gh_release_create
run: >-
gh release create ${TAG}
--verify-tag
--repo ${REPO}
--title ${TAG}
--generate-notesThat way, people watching this repo will be notified when you push a new tag. |
Uses
cibuildwheelto run unit tests on each binary wheel built (natively, withoutqemu).This could replace the current tests.yml workflow as it more accurately represents user experience during tests.
If removing test.yml in favor of this patch, then I would also adjust the CI triggers for wheels.yml (to run in PR sync events). See also #1366 for additional proposal.