fix: remove hotplug hitch with unified controller event flow#53
Open
MRZ07 wants to merge 1 commit into
Open
Conversation
1c8b137 to
7ab23c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ControllerEvent+ControllerEventQueueand core queue testsAndroidControllerEvent,GwtControllerEvent)Why
Controller hotplug could stall game frames, especially on desktop where native polling ran on the render thread. This change centralizes event flow and minimizes work done in connection paths across all backends.
Verification
JAVA_HOME="/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home" ./gradlew :gdx-controllers-core:test --tests '*ControllerEventQueueTest'JAVA_HOME="/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home" ./gradlew :test:desktop:build :test:lwjgl3:buildJAVA_HOME="/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home" ./gradlew :test:ios:buildJAVA_HOME="/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home" ./gradlew :test:html:buildJAVA_HOME="/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home" ./gradlew :gdx-controllers-core:testKnown environment limitation
:test:android:buildDebugcould not be run locally because Android SDK is not configured in this environment (ANDROID_HOME/local.propertiesmissing).