Open
Conversation
beautifulentropy
force-pushed
the
observer-memory-reduction
branch
from
31584ef to
aec1a8f
Compare
aarongable
approved these changes
Feb 26, 2026
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
It makes me slightly nervous to have a shared client, if some future prober wants to modify that client before using it. But today every call is merely obsclient.Client().Do(), so it works for now.
jsha
approved these changes
Feb 26, 2026
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Optional: since we have objects to attach them to (CRLProbe, HTTPProbe), it would be a little nicer to create the client at object creation time and store it as a field, instead of using globals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse shared HTTP clients and transports instead of initializing a new client for every probe request, and close HTTP response bodies in CRL, HTTP, and TLS probers.
These changes line up well with the heap and goroutine profiles, which show
net/httptransport churn and a large number ofnet/http.(*persistConn).readLoop/writeLoopgoroutines accumulating, consistent with connections and associated transport buffers not being closed promptly.Fixes #8650