fix(controls): Support ExpandDirection and clicking anywhere on header to expand (Expander.xaml)#1664
Open
Alex4SSB wants to merge 8 commits intolepoco:mainfrom
Open
fix(controls): Support ExpandDirection and clicking anywhere on header to expand (Expander.xaml)#1664Alex4SSB wants to merge 8 commits intolepoco:mainfrom
Alex4SSB wants to merge 8 commits intolepoco:mainfrom
Conversation
Setting HorizontalAlignment=Right when FlowDirection is RightToLeft achieves the exact opposite of the desired if the RadioButton's parent is also set to RightToLeft. This apparently also prevents any derived styles (and even direct control properties) from changing this behavior.
• ToggleButton and ContentPresenter are docked accordingly • BorderThickness and CornerRadius are adjusted accordingly • RenderTransform direction is adjusted accordingly
- Chevron is now rotated according to ExpandDirection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WPF expander has a built-in property for ExpandDirection, which sometimes can be useful. Also, clicking in the bottom/top 1/4 of the expander header's height doesn't expand it.
Also, there was a TODO in the gallery Expander page - that's dealt with now, at least for the regular Expander, not for the CardExpander.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The Expander now fully supports ExpandDirection:
Notes
Currently in the gallery app, Down (default), Left and Right directions work correctly, but Up lacks correct animation, until cycled through Left / Right first. Shouldn't a problem for most library users though, as an Expander rarely has its direction changed at run-time like in the gallery.