Skip to content

feat: add shift factor support - #903

Merged
leejet merged 1 commit into
masterfrom
shift_factor
Oct 22, 2025
Merged

feat: add shift factor support#903
leejet merged 1 commit into
masterfrom
shift_factor

Conversation

@leejet

@leejet leejet commented Oct 19, 2025

Copy link
Copy Markdown
Owner
.\bin\Release\sd.exe --diffusion-model  ..\models\flux1-dev-q8_0.gguf --vae ..\..\ComfyUI\models\vae\ae.sft --clip_l ..\..\ComfyUI\models\clip\clip_l.safetensors --t5xxl ..\..\ComfyUI\models\clip\t5-v1_1-xxl-encoder-Q8_0.gguf  -p "a lovely cat holding a sign says 'flux.cpp'" --cfg-scale 1.0 --sampling-method euler -v

Without shift factor
without_shift_factor

With shift factor
with_shift_factor

@Green-Sky

Copy link
Copy Markdown
Contributor

Seems to slightly reduce the vertical lines, but hard to tell.
Maybe test with less steps or lower quant?

@stduhpf

stduhpf commented Oct 19, 2025

Copy link
Copy Markdown
Contributor
theyre-the-same-picture-3

@Green-Sky

Green-Sky commented Oct 19, 2025

Copy link
Copy Markdown
Contributor
image

diff boosted

animated:
shift_anim1
shift_anim1_labels_2x
(a -> after, b -> before)

@stduhpf

stduhpf commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

Looks to have about the same diff as VAE tiling on vs off, maybe even less

@leejet

leejet commented Oct 19, 2025

Copy link
Copy Markdown
Owner Author

I didn’t really pay attention to the differences in the vertical lines — the purpose of this PR is simply to follow the official pipeline and include the handling of the shift factor.

@Green-Sky

Copy link
Copy Markdown
Contributor

I didn’t really pay attention to the differences in the vertical lines — the purpose of this PR is simply to follow the official pipeline and include the handling of the shift factor.

I figured as much, bit it still lowers the vertical line artifacts a bit. At least with that limited testing. I'm currently looking into chroma.

@Green-Sky

Green-Sky commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Looks about the same with chroma. I tried the flash variant, but it looks all smudgy, so its even harder to see a difference. I gotta make a proper chroma setup in the future so I can test better.

shift_anim2_2x

:shipit:

@leejet

leejet commented Oct 22, 2025

Copy link
Copy Markdown
Owner Author

I believe this PR is ready to be merged, as it adheres to the official pipeline.

@leejet
leejet merged commit 48e0a28 into master Oct 22, 2025
9 checks passed
@leejet

leejet commented Oct 22, 2025

Copy link
Copy Markdown
Owner Author

Thank you all for your tests.

@leejet
leejet deleted the shift_factor branch October 28, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants