feat: finish CMRA.lean - #614
Open
markusdemedeiros wants to merge 4 commits into
Open
Conversation
markusdemedeiros
marked this pull request as ready for review
August 12, 2026 01:03
2 tasks
|
|
||
| variable {α β : Type _} [CMRA α] [CMRA β] | ||
|
|
||
| @[rocq_alias option_fmap_mono] |
Collaborator
Author
There was a problem hiding this comment.
NOTE: Duplicated in #617. Delete before merging if gmap wins the race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Finish a bunch of CMRA lemmas.
Only thing I really noticed on review was that Rocq uses Empty_set. This PR aliases it to a the Lean type
Empty... they're both empty inductive types, andEmpty_setseems to serve the same purpose, but it's also stated as this strangeEnsemblething so I'm not 100%.Checklist
authorssection of any appropriate filesGenerative AI Guidelines
AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.
havestatements that do not aid readability or code reuse should be inlined.In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.