Skip to content

feat: finish CMRA.lean - #614

Open
markusdemedeiros wants to merge 4 commits into
masterfrom
finish-cmra
Open

feat: finish CMRA.lean #614
markusdemedeiros wants to merge 4 commits into
masterfrom
finish-cmra

Conversation

@markusdemedeiros

@markusdemedeiros markusdemedeiros commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Description

Finish a bunch of CMRA lemmas.

Only thing I really noticed on review was that Rocq uses Empty_set. This PR aliases it to a the Lean type Empty... they're both empty inductive types, and Empty_set seems to serve the same purpose, but it's also stated as this strange Ensemble thing so I'm not 100%.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros
markusdemedeiros marked this pull request as ready for review August 12, 2026 01:03

variable {α β : Type _} [CMRA α] [CMRA β]

@[rocq_alias option_fmap_mono]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Duplicated in #617. Delete before merging if gmap wins the race.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant