Bump to Lean v4.33.0; support prebuilt system libraries - #198
Merged
Conversation
- lean-toolchain -> v4.33.0, aesop -> 3448c0bcc5ce01b2d1546e483ec3620e32df3d0e, batteries -> 4488d40d070b9700d4d5a6aa342f0d40c31b2a2d. LeanCopilot itself builds and links cleanly against this toolchain (verified locally, including the lean_exe smoke test for #196). - Add -KsystemOpenblas / -KsystemCtranslate2Lib / -KsystemCtranslate2Include lake config options so distros that already package OpenBLAS/CTranslate2 (e.g. Nix) can point Lean Copilot at their own prebuilt libraries instead of cloning and compiling from source, fixing #187. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lean-toolchaintov4.33.0,aesopto3448c0bcc5ce01b2d1546e483ec3620e32df3d0e, andbatteriesto4488d40d070b9700d4d5a6aa342f0d40c31b2a2d.-KsystemOpenblas/-KsystemCtranslate2Lib/-KsystemCtranslate2Includelake config options so distros that already package OpenBLAS/CTranslate2 (e.g. Nix) can point Lean Copilot at prebuilt libraries instead of building from source, addressing Support passing in prebuilt system library dependencies #187.Test plan
lake build LeanCopilotsucceeds locally against the new toolchain/pins (709 jobs).lake build leanffi_exe_smoke_testsucceeds and the resulting binary runs correctly (regression test for lean_exe link fails with undefined libstdc++ symbols from libleanffi.a (lean_lib works fine) #196).-KsystemCtranslate2Lib/-KsystemCtranslate2Include/-KsystemOpenblasconfig options correctly skip the from-source build and copy prebuilt artifacts instead.🤖 Generated with Claude Code