Skip to content

feat: Add native-tls feature#119

Merged
keelerm84 merged 9 commits intofeat/hyper-as-featurefrom
mk/sdk-1904/native-certs
Feb 19, 2026
Merged

feat: Add native-tls feature#119
keelerm84 merged 9 commits intofeat/hyper-as-featurefrom
mk/sdk-1904/native-certs

Conversation

@keelerm84
Copy link
Member

No description provided.

@keelerm84 keelerm84 requested a review from a team as a code owner February 18, 2026 22:07
- name: Setup rust tooling
run: |
rustup override set ${{ steps.rust-version.outputs.target }}
run: rustup override set nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using stable? I question nightly just because it can, theoretically, be missing components.

Furthermore, nightly builds may be published with missing non-default components (such as clippy).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am only running nightly for the docs build. This is inline with what docs.rs does.

All crates are built in a sandbox using the nightly release of the Rust compiler. The current version in use is rustc 1.95.0-nightly (c04308580 2026-02-18).

The nightly functionality is what allows the doc(cfg()) annotations to work.

bytes = "1.5"

launchdarkly-sdk-transport = { git = "https://github.com/launchdarkly/rust-sdk-transport.git", branch = "main" }
launchdarkly-sdk-transport = { git = "https://github.com/launchdarkly/rust-sdk-transport.git", branch = "mk/sdk-1904/native-tls" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I presume temporary, but feel compelled to annotate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I will be cutting a release of that crate soon I hope, and then I can update this.

base64 = "0.22.1"

launchdarkly-sdk-transport = { git = "https://github.com/launchdarkly/rust-sdk-transport.git", branch = "main" }
launchdarkly-sdk-transport = { git = "https://github.com/launchdarkly/rust-sdk-transport.git", branch = "mk/sdk-1904/native-tls" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Base automatically changed from mk/sdk-1879/use-transport-crate to feat/hyper-as-feature February 19, 2026 17:40
@keelerm84 keelerm84 force-pushed the mk/sdk-1904/native-certs branch from 0df8c5f to 6dbac59 Compare February 19, 2026 17:42
@keelerm84 keelerm84 merged commit 523aff7 into feat/hyper-as-feature Feb 19, 2026
8 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1904/native-certs branch February 19, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments