Repository navigation
chore(deps-dev): bump eslint-plugin-react-hooks from 4.6.2 to 7.1.1 in /internal/dev_server/ui - #869
Conversation
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.6.2 to 7.1.1. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/react/react/blob/main/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/eslint-plugin-react-hooks@7.1.1/packages/eslint-plugin-react-hooks) --- updated-dependencies: - dependency-name: eslint-plugin-react-hooks dependency-version: 7.1.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
f474018 to
d16c1ce
Compare
Dependency verification: NEEDS A HUMAN DECISIONRisk tier high · ecosystems: npm-ui · head Decisions for a humanVerification is complete for these items. Each one needs a choice, not more checks.
Incomplete verificationThis item is not a decision and not a problem in this PR. A rerun of the failed CI job closes it.
Updates
4 transitive update(s)
What the verifier checked
Already failing on
|
| Check | Kind | Base | PR | Outcome |
|---|---|---|---|---|
| The UI ESLint configuration does not load eslint-plugin-react-hooks | guard | pass | pass | holds on both |
Impact review
eslint-plugin-react-hooks 4.6.2 → 7.1.1 is a devDependency that nothing loads. internal/dev_server/ui/eslint.config.js does not import it, and the resolved ESLint configuration has no react-hooks plugin or rule on either version. The 5.x to 7.x breaking changes (Node 18, flat config as the default recommended preset, preset renames, React Compiler rules in recommended, new violations) therefore change no lint result, test, or build. The update adds 4 MIT dev-only packages (hermes-estree, hermes-parser, zod, zod-validation-error). The question is the one that ui-dep-usage asks: remove the package instead of updating it.
- eslint-plugin-react-hooks 4.6.2..7.1.1: 5.0.0: new violations (component names must start with an uppercase letter, hooks in async functions), ESLint 9 support. 5.2.0: flat config support, TypeScript types. 6.0.0: released by mistake and deprecated. 6.1.0 (breaking): Node >=18, flat config is the default recommended preset, new violations for use() in try/catch and useEffectEvent in closures. 6.1.1: recommended-latest with React Compiler rules. 7.0.0 (breaking): only recommended and recommended-latest presets, all compiler rules on by default. 7.0.1: useEffectEvent JSX prop check, export = types. 7.1.0: ESLint 10 support, better set-state-in-effect and ref validation. 7.1.1: no-op component-hook-factories rule restored. Peer eslint ^3 to ^10, so eslint 8.57.0 is supported. (breaking) (source)
- Upstream behavior changes that reach ldcli: no
- Note: Not reachable: the guard reads
eslint --print-configfor src/App.tsx and eslint.config.js on both sides and finds no react-hooks plugin or rule. ui-lint, ui-prettier, ui-test, and ui-build-drift pass on the PR, and the committed dist/ matches a fresh build. (generated/ui-react-hooks-not-loaded.sh (guard), internal/dev_server/ui/eslint.config.js) - Note: Evidence for the removal question: if a follow-up enabled the plugin instead, its recommended rules report 5 exhaustive-deps warnings on 4.6.2, and the same 5 warnings plus 7 set-state-in-effect errors on 7.1.1 (for example src/ProjectSelector.tsx:56). The lint script uses --max-warnings 0, so enabling it on either version would need source changes first. Keeping the update gives no benefit until someone enables the plugin. (generated/ui-react-hooks-not-loaded.sh (detail lines on base and PR))
- Note: New transitive packages, all MIT and dev-only, with no install scripts: hermes-estree 0.25.1, hermes-parser 0.25.1, zod 4.6.5, zod-validation-error 4.0.2.
@babel/coreand@babel/parserwere already in the tree. engines node >=18 is satisfied by the CI Node (lts/*). (state/checks/transitive-changes/pr/details.md, state/checks/license-changes/pr/details.md)
Check details
ci-status
Workflows that PR CI must run on d16c1ce, and their runs on that commit:
| Workflow | Event | Run | Result |
|---|---|---|---|
.github/workflows/dependency-scan.yml |
pull_request | 38985543570 2026-10-17 | pass: success |
.github/workflows/dev-server-ui.yml |
pull_request | 38985543539 2026-10-17 | pass: success |
.github/workflows/go.yml |
pull_request | 38985543546 2026-10-17 | FAIL: failure in 1 job(s) |
.github/workflows/lint-pr-title.yml |
pull_request_target | 38985567432 2026-10-17 | pass: success |
- Correction: the go.yml failure is
TestStreamClientV2Handlerininternal/dev_server/sdk, a flaky test onmain. It is not caused by this PR. See Incomplete verification. - Check
Cursor Bugbot: success - Check
Require additional human oversight on bot PRs: success - Check
semgrep-cloud-platform/scan: success
upstream-changes
eslint-plugin-react-hooks4.6.2 → 7.1.1: facebook/react, 4744 commits, 300 files, notes: packages/eslint-plugin-react-hooks/CHANGELOG.md, full range, mentions: breaking (6), deprecation (2), requirements (2)
transitive-changes
- npm-ui (package-lock.json): 1 changed, 4 added, 0 removed
eslint-plugin-react-hooks4.6.2 → 7.1.1 (major)- added
hermes-estree@0.25.1 - added
hermes-parser@0.25.1 - added
zod-validation-error@4.0.2 - added
zod@4.6.5
license-changes
eslint-plugin-react-hooks@7.1.1: MIT (dev only)hermes-estree@0.25.1: MIT (dev only)hermes-parser@0.25.1: MIT (dev only)zod-validation-error@4.0.2: MIT (dev only)zod@4.6.5: MIT (dev only)
ui-npm-ci
- node v22.22.2, npm 10.9.7. CI uses
node-version: lts/*.
ui-npm-ls
npm error invalid: react@18.3.1 internal/dev_server/ui/node_modules/react
npm error invalid: react-dom@18.3.1 internal/dev_server/ui/node_modules/react-dom
ui-dep-usage
eslint-plugin-react-hooksrequires node>=18eslint-plugin-react-hookspeers: eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0 || ^9.0.0 || ^10.0.0eslint-plugin-react-hooksis not imported in src/ or referenced by tooling
binary-smoke
ldcli --version: ldcli version dev- dev-server served /ui/ (1160 KB) and /dev/projects (
[])
generated: ui-react-hooks-not-loaded
- eslint-plugin-react-hooks 7.1.1: the resolved configuration for src/App.tsx and eslint.config.js has no react-hooks plugin or rule
- If a follow-up enabled the recommended rules of 7.1.1: react-hooks/exhaustive-deps (warning): 5, react-hooks/set-state-in-effect (error): 7
Generated by scripts/dependency-pr/verify.sh (profile full) at 2026-10-17T00:29:59Z. The verifier does not approve or merge.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
… change On #869, an npm-only PR, the flaky TestStreamClientV2Handler failed the Go job, and ci-status made the verdict block. verify.sh now records the failed jobs and steps of each run. If every failed step is a run step that reads only ecosystems that the PR does not change, the result is incomplete with a rerun of the failed job as the fix. ci-status also gives the age of the oldest run, and it is incomplete when the base branch changed a workflow after the run (#719). Co-authored-by: rniebla <rniebla@launchdarkly.com>
Bumps eslint-plugin-react-hooks from 4.6.2 to 7.1.1.
Release notes
Sourced from eslint-plugin-react-hooks's releases.
Changelog
Sourced from eslint-plugin-react-hooks's changelog.
... (truncated)
Commits
Note
Overview
Upgrades
eslint-plugin-react-hooksininternal/dev_server/uifrom 4.6.2 to 7.1.1, with matchingpackage-lock.jsonupdates.The lockfile reflects the plugin’s new requirements: Node ≥18, broader ESLint peer support (including v9/v10), and added transitive deps (
hermes-parser,zod, etc.). No ESLint config or app source changes are in this diff—only the declared dev dependency version.Reviewed by Cursor Bugbot for commit d16c1ce. Bugbot is set up for automated code reviews on this repo. Configure here.