Skip to content

Add Mail user sender controls#1629

Open
cong-we wants to merge 1 commit into
larksuite:mainfrom
cong-we:feat/bd3103d
Open

Add Mail user sender controls#1629
cong-we wants to merge 1 commit into
larksuite:mainfrom
cong-we:feat/bd3103d

Conversation

@cong-we

@cong-we cong-we commented Jun 27, 2026

Copy link
Copy Markdown

Adds Mail API registry data and updates the lark-mail skill documentation so the CLI can expose user-level allow/block sender operations.

  • Adds registry metadata for user mailbox allow-sender and blocked-sender resources.
  • Documents user-token usage, required scopes, and command examples for listing, adding, and removing senders.
  • Refreshes the mail skill command catalog and scope reference for the new operations.

Summary by CodeRabbit

  • Documentation
    • Expanded guidance for Feishu mail tasks, including drafting, sending, replying, forwarding, reading, searching, and handling scheduled sends.
    • Added clearer instructions for safe email operations, recipient confirmation, sender allow/block lists, templates, and public mailbox “send as” use.
    • Improved HTML email guidance with formatting rules, linting behavior, and stronger content-handling recommendations.
    • Updated workflow and shortcut reference details for more consistent mail-related usage.

@cong-we cong-we requested a review from liangshuo-1 as a code owner June 27, 2026 13:04
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5d5c98a-5169-49bd-88a5-09c583b1a181

📥 Commits

Reviewing files that changed from the base of the PR and between 4c31323 and 58ad09a.

📒 Files selected for processing (2)
  • internal/registry/meta_data.json
  • skills/lark-mail/SKILL.md

📝 Walkthrough

Walkthrough

The mail skill guide was expanded with updated capability descriptions, safety confirmations, recipient search instructions, send and send_as workflows, HTML writing and linting rules, template and shortcut guidance, sender list operations, and refreshed API and permission tables.

Changes

Lark Mail skill documentation

Layer / File(s) Summary
Scope and safety baseline
skills/lark-mail/SKILL.md
Updated the skill description, startup instruction, core concepts, and confirmation rules for user-level sender list writes.
Workflow and recipient lookup
skills/lark-mail/SKILL.md
Reworked the workflow order, -h discovery guidance, and recipient search steps before using addresses.
Send, status, and send-as flow
skills/lark-mail/SKILL.md
Expanded send confirmation, send_status checks, scheduled-send handling, send_as, recall, sharing, calendar invites, and HTML-first composition rules.
HTML writing and templates
skills/lark-mail/SKILL.md
Revised HTML style constraints, raw EML restrictions, HTML lint behavior, read-output options, template handling, and raw API guidance.
Shortcut and sender list reference
skills/lark-mail/SKILL.md
Updated shortcut semantics and added +lint-html plus user-level sender allow/block list commands.
API resources and scopes
skills/lark-mail/SKILL.md
Expanded API resource listings and refreshed scopes for rules, threads, templates, and sender allow/block operations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • larksuite/cli#749: Introduces the mail safety rules that this PR extends for confirmation and untrusted-content handling.
  • larksuite/cli#1261: Covers the same mail read/triage shortcut semantics that this PR revises in the workflow and shortcut sections.
  • larksuite/cli#228: Overlaps on mail read output behavior, including structured JSON and --html=false handling.

Suggested reviewers

  • chanthuang
  • infeng

Poem

I hopped through SKILL.md with a twitchy nose,
🐰 From drafts to send_status, the mailbox glows.
I nibbled on HTML lint and template leaves,
Then waved at sender lists beneath the eaves.
Hop-hop—Feishu mail now sings in tune,
Under a carrot-bright June moon.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding user-level Mail sender controls.
Description check ✅ Passed The description covers summary and changes well, though it omits the template's Test Plan and Related Issues sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/XL Architecture-level or global-impact change labels Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/XL Architecture-level or global-impact change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants