Skip to content

fix: simplify mail triage read hint#1558

Open
bubbmon233 wants to merge 1 commit into
larksuite:mainfrom
bubbmon233:feat/7219331
Open

fix: simplify mail triage read hint#1558
bubbmon233 wants to merge 1 commit into
larksuite:mainfrom
bubbmon233:feat/7219331

Conversation

@bubbmon233

@bubbmon233 bubbmon233 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Generated by the harness-coding skill.

  • Branch: feat/7219331
  • Target: main

Sprints

ID Title Status Commit
S1 Simplify mail +triage full-content tip passed 6daeb5b

Summary

Update the lark-cli mail +triage output tip so it recommends only batch reading full content:

tip: read full content: use mail +messages --message-ids <id1>,<id2>,<id3>


This MR was created autonomously. Quality gates were enforced by the repo's own pre-commit hooks.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the read hint shown in mail triage views to recommend batch reading multiple messages with a single command.
    • Removed the older single-message and legacy multi-message suggestions from the tip message, keeping the guidance clearer and more consistent.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4926c5b-f1f2-46fd-9f2b-01fdd6c3311b

📥 Commits

Reviewing files that changed from the base of the PR and between d71bab0 and 6daeb5b.

📒 Files selected for processing (2)
  • shortcuts/mail/mail_read_help_test.go
  • shortcuts/mail/mail_triage.go

📝 Walkthrough

Walkthrough

The triage "tip: read full content" hint for mailbox != "me" is changed to recommend only mail +messages --mailbox <mailbox> --message-ids <id1>,<id2>,<id3>, removing the previous combined single-message and multi-message hint. The corresponding test is renamed and its assertions updated to verify the new batch-only message and assert the old hint forms are absent.

Changes

Triage Batch Read Hint

Layer / File(s) Summary
Triage hint output and test
shortcuts/mail/mail_triage.go, shortcuts/mail/mail_read_help_test.go
The mailbox != "me" tip in mail_triage.go now emits only the mail +messages --mailbox ... --message-ids ... form. TestMailTriageTableHintRoutesSingleAndMultipleReads is renamed to TestMailTriageTableHintRecommendsBatchRead and updated to assert the new batch-only tip text appears in stderr and that legacy single/multi-message hint strings do not.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • larksuite/cli#1261: Directly overlaps with changes to the triage tip routing in mail_triage.go and the related read hint test coverage in mail_read_help_test.go.

Suggested labels

domain/mail

Suggested reviewers

  • chanthuang

Poem

🐇 Hop, hop, one hint is enough,
No need for two when batch does the stuff.
Single messages? Gone from the tip!
Now --message-ids rules the trip.
One tidy line to rule them all — 🌟

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a summary, but it omits the required Changes, Test Plan, and Related Issues sections. Add the missing template sections with a bullet list of changes, verification steps, and related issues or None.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the main change to simplify the mail triage read hint.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact labels Jun 24, 2026
@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@6daeb5b009f5524a59743275d0de1b62b2aecc93

🧩 Skill update

npx skills add bubbmon233/cli#feat/7219331 -y -g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/mail PR touches the mail domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant