fix(openweather): invoke fall-through, request timeouts, and credential validator status-before-json

[Harsh23Kashyap]

Summary

Fixes #3441.

The openweather tool plugin v0.0.8 has four real reliability bugs that are user-visible in any Dify installation: the tool keeps executing the HTTP request after yielding an error message, both outbound requests.get calls have no timeout=, and the credential validator crashes with JSONDecodeError on any non-JSON failure page (e.g. a Cloudflare 502). This PR ships five small commits that fix all four bugs, add a test suite covering the new behavior, and bumps the plugin version.

Change Type

• Documentation / non-plugin change
• Non-LLM plugin (tools, extensions, datasource, etc.)
• LLM plugin

Screenshots / Videos

Before	After
Empty city → HTTP 400 {"message":"Nothing to geocode"}	Empty city → friendly "Please tell me your city", no HTTP call
Missing api_key → HTTP 401 failed:401	Missing api_key → friendly "OpenWeather API key is required.", no HTTP call
Hung OpenWeather host → 120 s Dify timeout	Hung host → clear error within ~12 s
Non-JSON 502 → JSONDecodeError stack trace	Non-JSON 502 → Openweather API rejected the key (HTTP 502): <snippet>

LLM Plugin Checklist

N/A — this is a Non-LLM tool plugin.

Version

• Bumped top-level version in manifest.yaml (not the one under meta)
• dify_plugin>=0.9.0 is declared in pyproject.toml and locked in uv.lock — unchanged from v0.0.8; the plugin already declared >=0.9.0 and this PR does not edit pyproject.toml or uv.lock

Bump: 0.0.8 → 0.0.9 (patch).

Commits in this PR

#	SHA	Subject
1	1e23207e	fix(openweather): return after error yields in tool invocation
2	c06d52e4	fix(openweather): add 10s timeout to all requests.get calls
3	bed926d2	fix(openweather): check response status before parsing json in credential validator
4	2d1f1bab	test(openweather): cover invoke fall-through, timeouts, credential validator status-before-json
5	8a4aaa83	chore(openweather): bump manifest version to 0.0.9

Testing

Local environment lacks requests and pytest, matching the convention used by other plugin test suites in this repo (e.g. tools/github/tests/test_refresh_credentials.py). The new test file stubs both.

Verification command and result:

cd tools/openweather
python3 -m py_compile provider/openweather.py
python3 -m py_compile tools/weather.py
python3 -m py_compile tests/test_openweather.py

python3 -c "
import sys; sys.path.insert(0, 'tests')
import test_openweather as t
for n in sorted(x for x in dir(t) if x.startswith('test_')):
    getattr(t, n)()
print('all 7 tests pass')
"

All seven cases pass:

• test_invoke_missing_city_returns_message_and_no_http_call

• test_invoke_missing_api_key_returns_message_and_no_http_call

• test_invoke_success_yields_summary

• test_validate_credentials_http_400_with_html_body_surfaces_status

• test_validate_credentials_http_401_surfaces_message

• test_validate_credentials_missing_api_key_does_not_call_api

• test_requests_get_called_with_timeout_10

• Local deployment — Dify version: latest main (1.7+); plugin test environment is the same minimal stub environment used by tools/github/tests/test_refresh_credentials.py

• SaaS (cloud.dify.ai) — not applicable; this is a tool-side behavior change

Risks

• User-visible error wording changes for the rare case where OpenWeather returns a non-JSON failure body in _validate_credentials. The new wording includes the HTTP status and a 200-char body snippet, replacing the previous JSONDecodeError crash. This is the desired UX.
• Successful tool responses are byte-identical (no response-shape change on the 200 path).
• query_weather() keeps the same signature; the timeout kwarg has a default of 10 so the only call site (_validate_credentials) does not need updating.

Files changed

tools/openweather/provider/openweather.py   | 18 +++++++++++++++++--
tools/openweather/tests/__init__.py         |  0 (new, empty)
tools/openweather/tests/test_openweather.py | 319 ++++++++++++++++++++++++++++ (new)
tools/openweather/tools/weather.py          |  4 ++--
tools/openweather/manifest.yaml             |  2 +-
5 files changed, 339 insertions(+), 5 deletions(-)

[Harsh23Kashyap]

Pushed a rebase plus one follow-up commit. The follow-up fixes a pre-existing bug in the test file:

The requests stub used sys.modules.setdefault("requests", _fake_requests). Under pytest, several plugins (respx, pytest-recording, syrupy, etc.) pre-load the real requests module before the test file runs, so setdefault was a no-op. The tool ended up importing the real requests, the patch.object(real_requests, "get", rec) never reached the tool, and two tests (test_invoke_success_yields_summary, test_requests_get_called_with_timeout_10) were silently failing.

Changed the stub to sys.modules["requests"] = _fake_requests (direct assignment). Also applied ruff format and added a # noqa: F401 on the intentional import tools.weather line.

Now: pytest tests/ → 7 passed. ruff check → All checks passed. Branch is 0 behind upstream/main.