Skip to content

fix(ci): pin python-version to 3.12.7 in pre-pr-check workflow - #3398

Open
Harsh23Kashyap wants to merge 1 commit into
langgenius:mainfrom
Harsh23Kashyap:fix/python-version-pin-pre-pr-check
Open

fix(ci): pin python-version to 3.12.7 in pre-pr-check workflow#3398
Harsh23Kashyap wants to merge 1 commit into
langgenius:mainfrom
Harsh23Kashyap:fix/python-version-pin-pre-pr-check

Conversation

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor

Summary

Fixes #3397

setup-python@v5 resolves python-version: '3.12' to the latest 3.12.x patch on the runner image, which can drift over time. upload-merged-plugin.yaml already pinned 3.12.7. PR-check vs merged-upload could therefore run against different Python patches as runner images updated. Pin both to 3.12.7 for reproducible behavior.

Change Type

  • Documentation / non-plugin change (CI workflow)
  • Non-LLM plugin (tools, extensions, datasource, etc.)
  • LLM plugin

Version

  • Bumped top-level version in manifest.yaml (not the one under meta) — N/A (workflow-only change)
  • dify_plugin>=0.9.0 is declared in pyproject.toml (or kept in requirements.txt for legacy plugins without uv.lock) — N/A

Verification

  • YAML structural sanity: 102 open / 102 close braces balanced, all top-level keys present (name, on, jobs).
  • python-version: 3.12.7 now present in both .github/workflows/pre-pr-check-per-plugin.yaml (L82) and .github/workflows/upload-merged-plugin.yaml (L78).
  • Diff is 1 insertion / 1 deletion in a single file.

Notes

  • No code logic affected. The change is a build/CI version pin.
  • Plugins run the same Python interpreter in both the pre-pr-check CI step and the merged-upload CI step going forward.
  • Bumping the pin in lockstep is a single follow-up edit when 3.12.x advances.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/python-version-pin-pre-pr-check branch from acfae42 to 9892915 Compare July 9, 2026 14:35
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

3 similar comments
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/python-version-pin-pre-pr-check branch from dc6fbe6 to e94073d Compare July 14, 2026 11:35
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

1 similar comment
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

The pre-pr-check-per-plugin.yaml workflow was using `python-version: '3.12'`,
which setup-python@v5 resolves to the latest 3.12.x patch on the runner
image. The upload-merged-plugin.yaml workflow already pins `3.12.7` so
PR-test vs merged-upload could run against different Python patches as
runner images drifted. Pin both to the same patch for reproducible
behavior.

Fixes langgenius#3397
@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/python-version-pin-pre-pr-check branch from d65a834 to ed40913 Compare July 27, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin Python to 3.12.7 in pre-pr-check-per-plugin.yaml to match upload-merged-plugin.yaml

1 participant