Skip to content

fix(aws_s3_storage): rename misnamed provider class - #3366

Merged
crazywoola merged 3 commits into
langgenius:mainfrom
Harsh23Kashyap:fix/aws-s3-provider-class-name
Aug 1, 2026
Merged

fix(aws_s3_storage): rename misnamed provider class#3366
crazywoola merged 3 commits into
langgenius:mainfrom
Harsh23Kashyap:fix/aws-s3-provider-class-name

Conversation

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor

Fixes #3365

The AWS S3 Storage datasource provider used GoogleCloudStorageDatasourceProvider, the same class name as the Google Cloud Storage plugin. Renamed to AwsS3StorageDatasourceProvider to match other datasource providers. Bumped patch version to 0.3.12.

Change Type

  • Non-LLM plugin (tools, extensions, datasource, etc.)

Testing

  • python3 -m py_compile datasources/aws_s3_storage/provider/aws_s3_storage.py

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of the aws_s3_storage plugin to 0.3.12 in manifest.yaml and corrects the class name in aws_s3_storage.py from GoogleCloudStorageDatasourceProvider to AwsS3StorageDatasourceProvider. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from b1395a5 to 9e1160e Compare June 30, 2026 13:46
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Synced with latest main. Okay, please review it.

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from cedf396 to c9d9745 Compare July 4, 2026 12:47
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

2 similar comments
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from 509dcd8 to 5e1fe99 Compare July 7, 2026 11:22
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

2 similar comments
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from 30abfc7 to 45cb26f Compare July 9, 2026 14:35
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

3 similar comments
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from 4b6cfca to 5f8ba19 Compare July 14, 2026 11:34
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

1 similar comment
@Harsh23Kashyap

Copy link
Copy Markdown
Contributor Author

Can someone take a look when you have a chance?

Harsh Kashyap and others added 3 commits July 27, 2026 21:03
@Harsh23Kashyap
Harsh23Kashyap force-pushed the fix/aws-s3-provider-class-name branch from 896454e to be64b30 Compare July 27, 2026 15:34
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2026
@crazywoola
crazywoola deployed to datasources/aws_s3_storage August 1, 2026 01:32 — with GitHub Actions Active
@crazywoola
crazywoola merged commit 4e8148b into langgenius:main Aug 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_s3_storage provider uses Google Cloud Storage class name

2 participants