fix: conflict a write with a metadata change to a field it wrote

rust/lance/src/io/commit.rs

@@ -1371,7 +1371,6 @@ pub(crate) async fn commit_transaction(
     // has not necessarily. So for anything involving writing, use `object_store`.
     let read_version = transaction.read_version;
     let mut target_version = read_version + 1;
-    let original_dataset = dataset.clone();
 
     // read_version sometimes defaults to zero for overwrite.
     // If num_retries is zero, we are in "strict overwrite" mode.
@@ -1388,6 +1387,9 @@ pub(crate) async fn commit_transaction(
             dataset.clone()
         };
 
+    // `dataset` advances past the read version inside the retry loop.
+    let read_version_dataset = dataset.clone();
+
     let mut transaction = transaction.clone();
 
     let num_attempts = std::cmp::max(commit_config.num_retries, 1);
@@ -1418,7 +1420,8 @@ pub(crate) async fn commit_transaction(
             // started at exact same time better.
 
             let mut rebase =
-                TransactionRebase::try_new(&original_dataset, transaction, affected_rows).await?;
+                TransactionRebase::try_new(&read_version_dataset, transaction, affected_rows)
+                    .await?;
 
             for (other_version, other_transaction) in other_transactions.iter() {
                 rebase.check_txn(other_transaction, *other_version)?;