-
Notifications
You must be signed in to change notification settings - Fork 804
feat(java): expose manifest writer version #8451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
everySympathy
wants to merge
4
commits into
lance-format:main
Choose a base branch
from
everySympathy:codex/java-manifest-info
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+163
−1
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.lance; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| /** Version metadata for the library that wrote a dataset manifest. */ | ||
| public final class WriterVersion { | ||
| private final String library; | ||
| private final String version; | ||
| private final String prerelease; | ||
| private final String buildMetadata; | ||
|
|
||
| WriterVersion(String library, String version, String prerelease, String buildMetadata) { | ||
| this.library = library; | ||
| this.version = version; | ||
| this.prerelease = prerelease; | ||
| this.buildMetadata = buildMetadata; | ||
| } | ||
|
|
||
| /** Name of the writer library, such as {@code lance}. */ | ||
| public String getLibrary() { | ||
| return library; | ||
| } | ||
|
|
||
| /** | ||
| * Version string reported by the writer library. | ||
| * | ||
| * <p>This value is opaque because writer libraries are not required to use semantic versioning. | ||
| * When a writer does use semantic versioning, newer writers store the core version here and | ||
| * expose prerelease and build metadata separately. | ||
| */ | ||
| public String getVersion() { | ||
| return version; | ||
| } | ||
|
|
||
| /** Optional semantic-version prerelease component, when supplied by the writer. */ | ||
| public Optional<String> getPrerelease() { | ||
| return Optional.ofNullable(prerelease); | ||
| } | ||
|
|
||
| /** Optional semantic-version build metadata component, when supplied by the writer. */ | ||
| public Optional<String> getBuildMetadata() { | ||
| return Optional.ofNullable(buildMetadata); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new API also promises
Optional.empty()for legacy manifests and preserves prerelease/build qualifiers, but this coverage only exercises a newly written manifest’s present library/core version. Please add focused assertions for those boundary paths—existing legacy and prerelease fixtures can cover two of them—so JNI null/optional mapping regressions are caught.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially addressed on
942f3fd: the historical v0.7.5 assertion now covers the JNI null →Optional.empty()path. The qualifier test constructsWriterVersiondirectly, so it would still pass if JNI swapped or droppedprerelease/buildMetadata; qualifier transport remains uncovered. This non-blocking thread remains open.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on
7ae0f8e: the2.0.0-beta.1fixture now exercises prerelease presence and build-metadata absence throughDataset.getWriterVersion(). The focused suite passed 54 Java tests and 17 JNI Rust tests, closing the qualifier-mapping risk.