fix: support namespace-only add column operations#5177
Open
FANNG1 wants to merge 3 commits into
Open
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
FANNG1
changed the title
added 2 commits
June 11, 2026 15:54
…amespace_table Move the duplicated describe_table -> location + storage_options merge pattern into a single shared helper resolve_namespace_table() in utils.py and converge add_columns/add_columns_from/merge_columns_from (io.py), compact_files (compaction.py), create_scalar_index/create_index/ optimize_indices (index.py), and vector_search (search.py) onto it. - Fixes inconsistent None-location handling: the inline copies silently proceeded with uri=None, now all raise a clear ValueError. - Short-circuit when an explicit uri is provided: no describe_table RPC and no merging of another table's storage_options, removing the wrong-table credential hazard. - datasink.py (create/append/overwrite + declare_table write path) is intentionally left as-is since its semantics differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_columns,add_columns_from, andmerge_columns_fromlocationviadescribe_tablewhen callers providenamespace_impl + table_idwithout a URIstorage_optionswith user-provided options, with namespace values taking precedenceCloses #5176.
Tests
uv run --extra dev ruff check lance_ray/io.py tests/test_add_columns_from.pyuv run pytest tests/test_add_columns_from.py -q