chore: apply initial spotless formatting#24
Draft
wombatu-kun wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #23 (
build: add spotless, checkstyle, and enforcer plugin configuration). Marked as draft until #23 is merged — at thatpoint GitHub will recompute this PR's diff to show only the formatting
commits. Until then the diff includes both PRs' changes.
mvn spotless:applyon every file undersrc/main/java/**/*.javaand
src/test/java/**/*.java(31 files). Effect: google-java-formatlayout (2-space indent, 100-char line length), import order
org.apache.flink,,javax,java,#, removed unused imports, licenseheader rewritten to the short Apache 2.0 form.
LanceInputFormat.java:295— droppublicon theLanceSplitAssignerconstructor (
RedundantModifier— the enclosing class is private).LanceIndexBuilder.java:325— wrap theBuilder.m(int m)HNSWbuilder method in
// checkstyle.off: MethodName/// checkstyle.on: MethodName. The single-letterMis thestandard HNSW parameter; renaming would break public API.
LanceCatalog.java:512— split a 110-char log message string.LanceDynamicTableSource.java:280–283— add braces to theif/else ifoperator-flip chain (NeedBraces)..editorconfig: Javaindent_size4 → 2 to match the actualgoogle-java-format output Spotless writes. Without this, IDEs that
honour
.editorconfigwould re-indent files to 4-space and failmvn spotless:checkon every save.spotless-maven-pluginandmaven-checkstyle-pluginto thevalidateMaven phase (goalcheck). Nowmvn compile(and anylater phase) automatically enforces both, so style regressions
fail the build.
The reformatting commit is purely mechanical — no behavioural changes,
no test changes.