feat(ui): add Alibaba Cloud OSS storage support#242
Open
yoogoc wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds Alibaba Cloud OSS as an S3-compatible warehouse credential type across the OpenAPI schema and warehouse UI, including tab selection, initialization, access-key validation, STS defaults, and credential serialization. ChangesAlibaba OSS credential support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WarehouseAddDialog
participant WarehouseStorageS3
participant warehouseObjectAliyun
WarehouseAddDialog->>WarehouseStorageS3: Render aliyun-oss credential form
WarehouseStorageS3->>warehouseObjectAliyun: Apply S3-compatible STS defaults
WarehouseAddDialog->>warehouseObjectAliyun: Load imported or existing warehouse data
WarehouseStorageS3->>WarehouseAddDialog: Serialize validated aliyun-oss credentials
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/WarehouseAddDialog.vue`:
- Around line 648-650: Update the Aliyun OSS submission validation in
WarehouseStorageS3.vue so the s3-compat exemption does not bypass ARN validation
when STS is enabled. Require either assume-role-arn or sts-role-arn for Aliyun
OSS, while preserving the existing validation behavior for other storage
flavors.
In `@src/components/WarehouseStorageS3.vue`:
- Line 711: The submit-button disabled conditions do not consistently enforce
missing-region validation for Aliyun OSS. In
src/components/WarehouseStorageS3.vue at lines 711-711, 734-734, and 768-768,
replace each hardcoded AWS flavor/region check with the existing isRegionInvalid
computed property for the Create, Create split-button, and Update Profile
buttons.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 37b82490-f71f-44f2-84a0-b67881e630f8
⛔ Files ignored due to path filters (13)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/assets/aliyun.svgis excluded by!**/*.svgsrc/gen/management/client.gen.tsis excluded by!**/gen/**src/gen/management/client/index.tsis excluded by!**/gen/**src/gen/management/client/utils.gen.tsis excluded by!**/gen/**src/gen/management/core/auth.gen.tsis excluded by!**/gen/**src/gen/management/core/params.gen.tsis excluded by!**/gen/**src/gen/management/core/pathSerializer.gen.tsis excluded by!**/gen/**src/gen/management/core/queryKeySerializer.gen.tsis excluded by!**/gen/**src/gen/management/core/types.gen.tsis excluded by!**/gen/**src/gen/management/core/utils.gen.tsis excluded by!**/gen/**src/gen/management/sdk.gen.tsis excluded by!**/gen/**src/gen/management/types.gen.tsis excluded by!**/gen/**
📒 Files selected for processing (3)
openapi/management-open-api.yamlsrc/components/WarehouseAddDialog.vuesrc/components/WarehouseStorageS3.vue
yoogoc
force-pushed
the
add-aliyun-oss-support
branch
from
July 15, 2026 02:44
2727ff5 to
a2473a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lakekeeper/lakekeeper#1893
Summary by CodeRabbit