[scanner] fix: complete refresh icon animation consistency by clubanderson · Pull Request #21265 · kubestellar/console

clubanderson · 2026-07-18T09:57:46Z

Completes the work started in #21264 by applying the same refresh icon animation pattern to the one remaining component that had a real gap.

Changes

`web/src/components/security/SecurityComplianceTab.tsx`

Added isRefreshing?: boolean prop to the component interface and used it to conditionally apply animate-spin to the RefreshCw icon in the compliance refresh button. This is the only file from the issue's list that had both a clickable refresh button and an available loading state that was not being reflected in the icon animation.

`web/src/components/security/Security.tsx`

Passes isRefreshing={dataRefreshing || securityLoading || securityRefreshing} to SecurityComplianceTab so the parent's combined refresh state drives the icon spin.

Audit of remaining files from #21261

All other files flagged in the issue were audited and are already consistent:

File	Status
`feedback/FeatureRequestList.tsx`	✅ `cn('w-3 h-3', isLoading && 'animate-spin')`
`feedback/UpdatesTabGitHubContributionsSection.tsx`	✅ `isGitHubRefreshing ? 'animate-spin' : ''`
`feedback/UpdatesTab.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`events/Events.tsx`	✅ `refreshingAll && 'animate-spin'`
`rewards/RewardsPanel.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`compliance/SegregationOfDuties.tsx`	✅ `loading && 'animate-spin'`
`compliance/ChangeControlAudit.tsx`	✅ `isRetrying && 'animate-spin'`
`compliance/DataResidency.tsx`	✅ `isRetrying && 'animate-spin'`
`history/CardHistory.tsx`	✅ Static semantic icon (history entry type)
`settings/UpdateSettingsForm.tsx`	✅ Browser-reload button (synchronous)
`settings/sections/PersistenceSection.tsx`	✅ `syncing ? 'animate-spin' : ''`
`settings/sections/ProfileSection.tsx`	✅ `isSaving && 'animate-spin'`
`settings/sections/AgentSection.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`settings/sections/TokenUsageSection.tsx`	✅ Synchronous reset action
`settings/sections/AgentBackendSettings.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`settings/sections/LocalClustersSection.tsx`	✅ `isLoading ? 'animate-spin' : ''`
`settings/sections/GitHubTokenSection.tsx`	✅ `tokenTesting ? 'animate-spin' : ''`
`acmm/RepoPicker.tsx`	✅ `scan.isRefreshing ? 'animate-spin' : ''`
`widget/MiniDashboard.tsx`	✅ `isRefreshing && 'animate-spin'`
`gitops/GitOps.tsx`	✅ Sync-dialog trigger (not async fetch)
`terminal/PodExecTerminal.tsx`	✅ Always-spinning reconnect indicator
`PageErrorBoundary.tsx`	✅ Page-reload button (synchronous)
`dashboard/ReplaceCardModal.tsx`	✅ Header icon only
`dashboard/ResetDialog.tsx`	✅ Option visual icon
`drilldown/DrillDownModal.tsx`	✅ Error-state retry button
`drilldown/RemediationConsole.tsx`	✅ `isExecuting ? 'animate-spin' : ''`
`drilldown/views/ArgoAppDrillDown.tsx`	✅ Section heading icon
`drilldown/views/RBACDrillDown.tsx`	✅ `refreshing && 'animate-spin'`
`drilldown/views/DeploymentDrillDown.tsx`	✅ `isRefreshing && 'animate-spin'`
`drilldown/views/HelmReleaseDrillDown.tsx`	✅ Metadata label icon ("Revision")
`drilldown/views/OperatorDrillDown.tsx`	✅ Metadata label icon ("Channel")
`drilldown/views/KustomizationDrillDown.tsx`	✅ No clickable RefreshCw button
`drilldown/views/PodDrillDown.tsx`	✅ `isRefreshing && 'animate-spin'`
`drilldown/views/YAMLDrillDown.tsx`	✅ `isLoading ? 'animate-spin' : ''`
`drilldown/views/LogsDrillDown.tsx`	✅ `isLoading ? 'animate-spin' : ''`
`drilldown/views/pod-drilldown/PodRelatedTab.tsx`	✅ `relatedLoading && 'animate-spin'`
`drilldown/views/pod-drilldown/PodAiAnalysis.tsx`	✅ `aiAnalysisLoading && 'animate-spin'`
`drilldown/views/pod-drilldown/PodOutputTab.tsx`	✅ No RefreshCw button
`drilldown/views/EventsDrillDown.tsx`	✅ `isLoading ? 'animate-spin' : ''`
`drilldown/views/PolicyDrillDown.tsx`	✅ Metadata label icon ("Action")
`drilldown/views/BuildpackDrillDown.tsx`	✅ Metadata label icon ("Status")
`setup/DeveloperSetupDialog.tsx`	✅ Collapsible-section label icon
`cards/karmada_status/KarmadaStatus.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`cards/openyurt_status/OpenYurtStatus.tsx`	✅ Fixed in #21264
`cards/otel_status/index.tsx`	✅ `isRefreshing ? 'animate-spin' : ''`
`cards/failover_timeline/FailoverTimeline.tsx`	✅ Static event-type icon ("Rebalance")

Tie animate-spin on the SecurityComplianceTab refresh button to the actual refreshing state (dataRefreshing || securityLoading || securityRefreshing) propagated from Security.tsx. All other files flagged in #21261 were already addressed (either by PR #21264 or by earlier commits): the remaining RefreshCw usages are static semantic icons (metadata labels, section headers, history-type icons) that intentionally do not spin. Completes #21261 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@kubestellar.io>

netlify · 2026-07-18T09:57:51Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`5fb118c`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6a5b4e1d2fa3f00008c8668d
😎 Deploy Preview	https://deploy-preview-21265.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

kubestellar-prow · 2026-07-18T09:57:52Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-07-18T09:57:53Z

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

github-actions · 2026-07-18T09:57:55Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-07-18T09:58:14Z

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

github-actions · 2026-07-18T09:59:15Z

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.

Powered by axe-core. Target: WCAG 2.1 AA compliance.

Copilot

Pull request overview

This PR finishes the refresh-icon animation consistency work for the Security dashboard by wiring an isRefreshing state into the remaining compliance refresh button, so the RefreshCw icon can spin while refresh work is in progress.

Changes:

Extend SecurityComplianceTab with an optional isRefreshing prop and conditionally apply animate-spin to the refresh icon.
Pass a combined refresh/loading state from Security.tsx into SecurityComplianceTab so the tab’s refresh button reflects parent refresh activity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
web/src/components/security/SecurityComplianceTab.tsx	Adds `isRefreshing` prop and uses it to drive `RefreshCw` spin animation.
web/src/components/security/Security.tsx	Passes combined refresh/loading state into `SecurityComplianceTab`.

          <button
            onClick={handleRefresh}
            className="flex items-center gap-2 px-4 py-2 rounded-lg bg-secondary hover:bg-secondary/80 text-sm text-foreground transition-colors"
          >
-            <RefreshCw className="w-4 h-4" />
+            <RefreshCw className={cn('w-4 h-4', isRefreshing && 'animate-spin')} />


            className="flex items-center gap-2 px-4 py-2 rounded-lg bg-secondary hover:bg-secondary/80 text-sm text-foreground transition-colors"
          >
-            <RefreshCw className="w-4 h-4" />
+            <RefreshCw className={cn('w-4 h-4', isRefreshing && 'animate-spin')} />


github-actions · 2026-07-18T10:22:47Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-07-18T10:26:34Z

✅ Post-Merge Verification: passed

Commit: dafb7091db0f0ecf890eae71cb18fda15448d3b5
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/29640744337

github-actions · 2026-07-18T10:31:08Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit dafb7091db0f0ecf890eae71cb18fda15448d3b5.

Copilot AI review requested due to automatic review settings July 18, 2026 09:57

kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 18, 2026

github-actions Bot added ai-generated Pull request generated by AI tier/2-standard labels Jul 18, 2026

kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2026

Copilot started reviewing on behalf of clubanderson July 18, 2026 09:58 View session

Copilot AI reviewed Jul 18, 2026

View reviewed changes

clubanderson merged commit dafb709 into main Jul 18, 2026
51 of 55 checks passed

kubestellar-prow Bot deleted the scanner/fix-21261b branch July 18, 2026 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[scanner] fix: complete refresh icon animation consistency#21265

[scanner] fix: complete refresh icon animation consistency#21265
clubanderson merged 1 commit into
mainfrom
scanner/fix-21261b

clubanderson commented Jul 18, 2026

Uh oh!

netlify Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

kubestellar-prow Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

clubanderson commented Jul 18, 2026

Changes

web/src/components/security/SecurityComplianceTab.tsx

web/src/components/security/Security.tsx

Audit of remaining files from #21261

Uh oh!

netlify Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

kubestellar-prow Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

✅ Test Coverage Check

Uh oh!

github-actions Bot commented Jul 18, 2026

♿ Accessibility Audit (WCAG 2.1 AA)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026

✅ Post-Merge Verification: passed

Uh oh!

github-actions Bot commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

`web/src/components/security/SecurityComplianceTab.tsx`

`web/src/components/security/Security.tsx`

netlify Bot commented Jul 18, 2026 •

edited

Loading