fix: allow 1 CPU with --no-kubernetes flag #22168

AryanBagade · 2025-12-16T19:58:17Z

Summary

Skip the minimum CPU validation (requires 2 CPUs) when --no-kubernetes is set, since Kubernetes is not being run.

Changes

Added && !viper.GetBool(noKubernetes) to both CPU validation checks in validateCPUCount()
Added --cpus=1 to existing --no-kubernetes integration test to verify this behavior

Why

The 2 CPU minimum is a Kubernetes requirement (error messages say "Kubernetes requires at least 2"). When --no kubernetes is used, this requirement shouldn't apply.

Fixes #22152

k8s-ci-robot · 2025-12-16T19:58:26Z

Welcome @AryanBagade!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-16T19:58:27Z

Hi @AryanBagade. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

minikube-bot · 2025-12-16T19:59:03Z

Can one of the admins verify this patch?

Skip the minimum CPU validation (requires 2 CPUs) when --no kubernetes is set, since Kubernetes is not being run. Also adds --cpus=1 to existing integration test to verify this behavior. Signed-off-by: Aryan Bagade <[email protected]>

nirs

Tanks @AryanBagade

/lgtm

k8s-ci-robot · 2025-12-16T23:38:37Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AryanBagade, nirs
Once this PR has been reviewed and has the lgtm label, please assign medyagh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nirs · 2025-12-16T23:39:03Z

/ok-to-test

nirs · 2025-12-17T00:20:30Z

Tested with vfkit on macOS:

% time out/minikube start -d vfkit --cpus 1 --no-kubernetes 
😄  minikube v1.37.0 on Darwin 26.2 (arm64)
✨  Using the vfkit driver based on user configuration
👍  Starting minikube without Kubernetes in cluster minikube
🔥  Creating vfkit VM (CPUs=1, Memory=6144MB, Disk=20000MB) ...
🐳  Preparing Docker 28.5.2 ...
🏄  Done! minikube is ready without Kubernetes!
╭───────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                       │
│                       💡  Things to try without Kubernetes ...                        │
│                                                                                       │
│    - "minikube ssh" to SSH into minikube's node.                                      │
│    - "minikube docker-env" to point your docker-cli to the docker inside minikube.    │
│    - "minikube image" to build images without docker.                                 │
│                                                                                       │
╰───────────────────────────────────────────────────────────────────────────────────────╯
out/minikube start -d vfkit --cpus 1 --no-kubernetes  0.24s user 0.34s system 10% cpu 5.501 total

minikube-pr-bot · 2025-12-17T00:32:37Z

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22168 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 39.4s    │ 39.8s                  │
│ enable ingress │ 15.7s    │ 15.7s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 40.1s 39.7s 39.2s 38.2s 39.7s
Times for minikube (PR 22168) start: 41.4s 41.1s 38.2s 39.5s 38.6s

Times for minikube ingress: 15.7s 15.7s 15.8s 15.7s 15.8s
Times for minikube (PR 22168) ingress: 15.8s 15.8s 15.7s 15.2s 15.8s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22168 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.5s    │ 23.3s                  │
│ enable ingress │ 35.1s    │ 11.4s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube ingress: 10.6s 40.6s 73.1s 10.7s 40.6s
Times for minikube (PR 22168) ingress: 12.6s 10.6s 12.7s 10.6s 10.6s

Times for minikube (PR 22168) start: 23.4s 20.5s 23.9s 23.6s 25.3s
Times for minikube start: 19.3s 22.1s 19.5s 22.2s 24.5s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 22168 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 21.2s    │ 19.5s                  │
│ enable ingress │ 20.3s    │ 20.7s                  │
└────────────────┴──────────┴────────────────────────┘

Details

Times for minikube start: 20.2s 21.5s 22.2s 19.7s 22.5s
Times for minikube (PR 22168) start: 21.7s 19.0s 18.8s 19.4s 18.7s

Times for minikube ingress: 20.2s 21.1s 20.1s 20.1s 20.2s
Times for minikube (PR 22168) ingress: 21.1s 21.1s 20.2s 20.1s 21.2s

AryanBagade · 2025-12-17T03:08:38Z

/retest

minikube-pr-bot · 2025-12-17T04:04:28Z

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//data(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/docker(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/cni(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/kubelet(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/minikube(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/toolbox(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/PersistentMounts//var/lib/boot2docker(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/VersionJSON(gopogh)	Unknown
KVM_Linux (9 failed)	TestISOImage/eBPFSupport(gopogh)	Unknown

Besides the following environments also have failed tests:

Docker_Windows: 35 failed (gopogh)
KVM_Linux_crio: 14 failed (gopogh)
Docker_Linux_crio_arm64: 46 failed (gopogh)
Docker_Linux_containerd_arm64: 34 failed (gopogh)
Docker_Linux_crio: 26 failed (gopogh)

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2025-12-18T02:18:26Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-12-18T21:28:55Z

@AryanBagade: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
integration-vfkit-docker-macos-arm64	`9b78784`	link	false	`/test integration-vfkit-docker-macos-arm64`
integration-docker-crio-linux-x86-64	`9b78784`	link	true	`/test integration-docker-crio-linux-x86-64`
integration-kvm-crio-linux-x86-64	`9b78784`	link	true	`/test integration-kvm-crio-linux-x86-64`
integration-kvm-docker-linux-x86	`9b78784`	link	true	`/test integration-kvm-docker-linux-x86`
integration-kvm-containerd-linux-x86	`9b78784`	link	true	`/test integration-kvm-containerd-linux-x86`
integration-none-docker-linux-x86	`9b78784`	link	true	`/test integration-none-docker-linux-x86`
integration-docker-docker-linux-x86	`9b78784`	link	true	`/test integration-docker-docker-linux-x86`
integration-kvm-crio-linux-x86	`9b78784`	link	true	`/test integration-kvm-crio-linux-x86`
integration-docker-containerd-linux-x86	`9b78784`	link	true	`/test integration-docker-containerd-linux-x86`
integration-docker-crio-linux-x86	`9b78784`	link	true	`/test integration-docker-crio-linux-x86`
integration-docker-docker-linux-arm	`9b78784`	link	true	`/test integration-docker-docker-linux-arm`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 16, 2025

k8s-ci-robot requested review from medyagh and nirs December 16, 2025 19:58

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2025

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2025

AryanBagade force-pushed the fix/allow-1-cpu-no-kubernetes branch from f9d7042 to f6adc98 Compare December 16, 2025 20:06

fix: allow 1 CPU with --no-kubernetes flag

9b78784

Skip the minimum CPU validation (requires 2 CPUs) when --no kubernetes is set, since Kubernetes is not being run. Also adds --cpus=1 to existing integration test to verify this behavior. Signed-off-by: Aryan Bagade <[email protected]>

AryanBagade force-pushed the fix/allow-1-cpu-no-kubernetes branch from f6adc98 to 9b78784 Compare December 16, 2025 20:08

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 16, 2025

nirs approved these changes Dec 16, 2025

View reviewed changes

k8s-ci-robot assigned nirs Dec 16, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 16, 2025

nirs mentioned this pull request Dec 17, 2025

drivers: Introduce WaitForSSHAccess and fix macos smoke tests #22179

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: allow 1 CPU with --no-kubernetes flag #22168

fix: allow 1 CPU with --no-kubernetes flag #22168

AryanBagade commented Dec 16, 2025

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

minikube-bot commented Dec 16, 2025

Uh oh!

nirs left a comment

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

nirs commented Dec 16, 2025

Uh oh!

nirs commented Dec 17, 2025

Uh oh!

minikube-pr-bot commented Dec 17, 2025

Uh oh!

AryanBagade commented Dec 17, 2025

Uh oh!

minikube-pr-bot commented Dec 17, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix: allow 1 CPU with --no-kubernetes flag #22168

Are you sure you want to change the base?

fix: allow 1 CPU with --no-kubernetes flag #22168

Conversation

AryanBagade commented Dec 16, 2025

Summary

Changes

Why

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

minikube-bot commented Dec 16, 2025

Uh oh!

nirs left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Dec 16, 2025

Uh oh!

nirs commented Dec 16, 2025

Uh oh!

nirs commented Dec 17, 2025

Uh oh!

minikube-pr-bot commented Dec 17, 2025

Uh oh!

AryanBagade commented Dec 17, 2025

Uh oh!

minikube-pr-bot commented Dec 17, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

k8s-ci-robot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants