Skip to content

Conversation

@AvineshTripathi
Copy link

  • Add documentation about proper uninstall order to avoid finalizer deadlocks
  • Add recovery steps for stuck resources with manual finalizer removal
  • Remove CRDs from config/default since undeploy and uninstall earlier used to do the same thing.
  • CRDs are now managed separately via make install/make uninstall

Fixes: #48

@netlify
Copy link

netlify bot commented Dec 25, 2025

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit a7d3a22
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/694cf438d4f82e0008276b21

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AvineshTripathi
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 25, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @AvineshTripathi!

It looks like this is your first PR to kubernetes-sigs/node-readiness-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-readiness-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document best-practices to uninstall controller

2 participants