Skip to content

feat: add new examples under kubernetes/dogsvscats. #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
meetreks wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add new examples under kubernetes/dogsvscats. #903

meetreks wants to merge 3 commits into from

Conversation

@meetreks
Copy link
Contributor

@meetreks meetreks commented Dec 16, 2025 •
edited
Loading

This PR updates the examples present here
examples/kubernetes/dogsvscats/
I have added webstack-rgd folder to include 4 rgds and in /instances I am creating 3 instances which then creates different kubernetes objects in the cluster.

Next Steps:
Run Pipeline and merge

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: meetreks
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 16, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: meetreks / name: meetreks (003b048)
  • ✅ login: meetreks / name: Ramesh Mathikumar (68348d2, e2a79ff)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 16, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 16, 2025

Hi @meetreks. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 16, 2025
michaelhtm
michaelhtm reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @meetreks
left a few comments below

examples/kubernetes/dogsvscats/webstack-rgd/web-stack-rgd.yaml Outdated
enabled: ${schema.spec.elasticache.enabled}

# --- Result WebStack ---
- id: webapp
Copy link
Contributor

@michaelhtm michaelhtm Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see the reuse of webapp id here

Copy link
Contributor Author

@meetreks meetreks Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it unique now.

examples/kubernetes/dogsvscats/webstack-rgd/web-stack-rgd.yaml
Copy link
Contributor

@michaelhtm michaelhtm Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add an instance for this one as well?

Copy link
Contributor Author

@meetreks meetreks Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which one, but I made 3 unique ones now

Copy link
Contributor

@michaelhtm michaelhtm Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 4 rgds, but only 3 instances

Copy link
Contributor Author

@meetreks meetreks Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the "design" we are supposed to highlight 3 individual rgds and the 4th one web-stack is supposed to include them all in a single unified stack. The 3 instances are instances of web-stack with alternate parameters so that it creates different stacks. That is the design I am asked to implement.

a-hilaly
a-hilaly reviewed Dec 16, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meetreks - thank you for your CR - can you please sign the CLA? and fix the PR title and body?

@meetreks
Copy link
Contributor Author

meetreks commented Dec 17, 2025

@meetreks - thank you for your CR - can you please sign the CLA? and fix the PR title and body?

What is CLA?

@michaelhtm
Copy link
Contributor

michaelhtm commented Dec 17, 2025

What is CLA?

There should be more information about it here:
#668

@meetreks meetreks changed the title Initial Commit feat: add new examples under kubernetes/dogsvscats. Dec 17, 2025
@meetreks meetreks mentioned this pull request Dec 17, 2025
Closed
@michaelhtm
Copy link
Contributor

michaelhtm commented Dec 17, 2025

✅ login: meetreks / name: Ramesh Mathikumar (c1e3142)
❌ The email address for the commit (c291c4e) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

It looks like there's still an issue with the CLA. can you please address it?

@meetreks
Copy link
Contributor Author

meetreks commented Dec 18, 2025

✅ login: meetreks / name: Ramesh Mathikumar (c1e3142)
❌ The email address for the commit (c291c4e) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

It looks like there's still an issue with the CLA. can you please address it?

I followed the link and I get an email to say all is OK, not sure what the issue is.

@petrokashlikov
Copy link
Contributor

petrokashlikov commented Dec 18, 2025

✅ login: meetreks / name: Ramesh Mathikumar (c1e3142)
❌ The email address for the commit (c291c4e) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

It looks like there's still an issue with the CLA. can you please address it?

I followed the link and I get an email to say all is OK, not sure what the issue is.

I think issue is how commit was made. You can see now that one commit is passing check, but another one (initial commit) says that email is not linked to GitHub account. It was done by EC2 default user instead of your account.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 18, 2025
petrokashlikov
petrokashlikov suggested changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@petrokashlikov petrokashlikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge. WIP

@a-hilaly
Copy link
Member

a-hilaly commented Dec 23, 2025

/ok-to-test
/hold

@petrokashlikov please ping whenever this is ready to review.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2025
@a-hilaly a-hilaly added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2025
@a-hilaly
Copy link
Member

a-hilaly commented Dec 23, 2025

cc @meetreks

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-hilaly a-hilaly a-hilaly left review comments

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

@nicslatts nicslatts Awaiting requested review from nicslatts

+2 more reviewers

@michaelhtm michaelhtm michaelhtm left review comments

@petrokashlikov petrokashlikov petrokashlikov requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@meetreks @k8s-ci-robot @michaelhtm @petrokashlikov @a-hilaly