Skip to content

Conversation

@GnatorX
Copy link

@GnatorX GnatorX commented Dec 5, 2025

Fixes #N/A

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

GnatorX and others added 30 commits February 13, 2025 14:07
GnatorX and others added 6 commits September 19, 2025 18:11
This RFC proposes implementing a configurable readiness timeout by
leveraging Karpenter's existing node auto repair infrastructure,
rather than creating a separate timeout mechanism.

Key changes:
- Add readinessTTL field to NodePool and NodeClaim specs
- Generate dynamic RepairPolicies based on NodeClaim readinessTTL
- Reuse existing health controller for readiness timeouts
- Automatic 20% safety threshold protection

Addresses feedback from PR kubernetes-sigs#1989 to use node auto repair approach.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Committed-By-Agent: claude
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GnatorX
Once this PR has been reviewed and has the lgtm label, please assign derekfrank for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tallaxes December 5, 2025 04:58
@GnatorX GnatorX changed the title Readiness ttl rfc: Readiness ttl Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19953154884

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 80.305%

Files with Coverage Reduction New Missed Lines %
pkg/controllers/disruption/consolidation.go 4 88.0%
Totals Coverage Status
Change from base Build 19948193551: -0.03%
Covered Lines: 11865
Relevant Lines: 14775

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants