disk: ModifyVolume #1252

huww98 · 2024-12-05T10:01:50Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support for ModifyVolume for EBS (VolumeAttributesClass in k8s)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3751

k8s-ci-robot · 2024-12-05T10:01:53Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

huww98 · 2024-12-05T17:19:05Z

We have no way to enable the feature gate on managed ACK cluster now. So do not enable external-storage tests for now.

mowangdk · 2024-12-06T09:58:53Z

pkg/cloud/wrap/sdkv1.go

+	comparable
+}
+
+func V1[TReq requests.AcsRequest, TResp tResp](logger logr.Logger, f func(TReq) (TResp, error)) func(TReq) (TResp, error) {


Can we add some metrics here?

Yes, but maybe with another layer of wrapper

mowangdk · 2024-12-06T10:11:12Z

pkg/cloud/wrap/sdkv1.go

+		}
+	} else {
+		// No error code, just log entire error
+		attrs = append(attrs, "error", err)


I doubt there will be any other error types, better to add some warning logs here

mowangdk · 2024-12-06T10:13:32Z

pkg/cloud/wrap/sdkv1.go

+	comparable
+}
+
+func V1[TReq requests.AcsRequest, TResp tResp](logger logr.Logger, f func(TReq) (TResp, error)) func(TReq) (TResp, error) {


Does v2 version of sdk has a union interface?

No, we will need a separate V2 wrapper.

k8s-triage-robot · 2025-06-17T04:57:20Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

huww98 · 2025-06-23T07:54:00Z

/remove-lifecycle stale

liubog2008 · 2025-07-07T03:37:34Z

How about this feature now?

huww98 · 2025-07-07T05:15:45Z

@liubog2008 Should be basically ready. Since it is still not enabled by default in Kubernetes, we still missing e2e test on ACK. Also, we are waiting for kubernetes/enhancements#5381

liubog2008 · 2025-07-07T05:19:09Z

kubernetes/enhancements#5381

Is it necessary? I seems only a few params need this kep.

huww98 · 2025-07-07T05:24:20Z

kubernetes/enhancements#5381

Is it necessary? I seems only a few params need this kep.

Not necessary for every use-case. But it is necessary for modifying from/to regional ESSD (ESSD同城冗余云盘)

k8s-triage-robot · 2025-11-30T03:37:24Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Allow us to add more context to the "GRPC call start" related log entry.

Extract request ID, Error code from response or error for logging. Transform the error for k8s event. - Do not include anything that changes at each request (e.g. RequestID) in error message, for better event aggregation. RequestID is still present in the log. - Support using errors.Is() for checking error code programmatically.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2024

k8s-ci-robot requested review from mowangdk and tydra-wang December 5, 2024 10:01

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2024

huww98 force-pushed the disk-modify branch from 860428b to c3e3a06 Compare December 5, 2024 17:17

huww98 force-pushed the disk-modify branch 4 times, most recently from 8b9da21 to 39be879 Compare December 6, 2024 08:29

mowangdk reviewed Dec 6, 2024

View reviewed changes

huww98 force-pushed the disk-modify branch 2 times, most recently from a25c610 to ac61709 Compare December 13, 2024 04:07

huww98 marked this pull request as ready for review December 17, 2024 10:07

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2024

k8s-ci-robot requested a review from mowangdk December 17, 2024 10:07

huww98 force-pushed the disk-modify branch 2 times, most recently from bcf4323 to f751cd6 Compare December 19, 2024 06:47

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024

huww98 force-pushed the disk-modify branch from f751cd6 to 6d4c6ef Compare December 19, 2024 06:54

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024

huww98 force-pushed the disk-modify branch from 6d4c6ef to 2fc2ae4 Compare December 20, 2024 11:19

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2024

huww98 force-pushed the disk-modify branch from 2fc2ae4 to 0d3792f Compare December 24, 2024 09:06

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2024

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 14, 2025

huww98 force-pushed the disk-modify branch from 56385eb to a166c64 Compare March 19, 2025 04:25

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 17, 2025

huww98 force-pushed the disk-modify branch from a166c64 to 5b5e54c Compare June 23, 2025 07:53

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2025

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2025

huww98 force-pushed the disk-modify branch 2 times, most recently from 45cf494 to 492d0d7 Compare August 24, 2025 17:57

huww98 force-pushed the disk-modify branch from 492d0d7 to 675a336 Compare September 1, 2025 03:22

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 30, 2025

huww98 added 4 commits December 3, 2025 00:18

common: validation and ctx logging for new API

0189050

common: generic logGRPC

f6fc877

Allow us to add more context to the "GRPC call start" related log entry.

test: enable csi-sanity test for ModifyVolume

1382f63

huww98 force-pushed the disk-modify branch from 675a336 to 3ca5140 Compare December 2, 2025 16:32

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025

huww98 added 2 commits December 3, 2025 00:39

disk: implement ModifyVolume

b9a4a6e

waitstatus: document nil can be returned

dd7d376

huww98 force-pushed the disk-modify branch from 3ca5140 to dd7d376 Compare December 2, 2025 16:40

disk: ModifyVolume #1252

Are you sure you want to change the base?

disk: ModifyVolume #1252

Uh oh!

Conversation

huww98 commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Dec 5, 2024

Uh oh!

huww98 commented Dec 5, 2024

Uh oh!

mowangdk Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

huww98 Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

mowangdk Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

mowangdk Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

huww98 Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

k8s-triage-robot commented Jun 17, 2025

Uh oh!

huww98 commented Jun 23, 2025

Uh oh!

liubog2008 commented Jul 7, 2025

Uh oh!

huww98 commented Jul 7, 2025

Uh oh!

liubog2008 commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huww98 commented Jul 7, 2025

Uh oh!

k8s-triage-robot commented Nov 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

huww98 commented Dec 5, 2024 •

edited

Loading

liubog2008 commented Jul 7, 2025 •

edited

Loading