populate cluster config from client.authentication.k8s.io/exec extension#2396
populate cluster config from client.authentication.k8s.io/exec extension#2396wkloucek wants to merge 1 commit into
Conversation
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wkloucek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @wkloucek! |
|
Please sign the CLA. Also please add a unit test for this. |
|
Hi! Can this be implemented? @wkloucek: if the CLA is prohibited by your organisation, more than happy to re-contribute from our organisation. Merging this also fixes issues with the Azure CLI, connecting on-prem clusters to Azure (see Azure/azure-cli-extensions#8788). Validated that this fixes the issue there as well (by patching the function call manually) |
I'm currently waiting for my company to register for the CLA. I didn't hear back how long it's gonna take though |
|
Can I republish? More than happy to give you all credits |
What type of PR is this?
/kind bug
What this PR does / why we need it:
populate
ExecCredentialSpec.Cluster.configfrom theclient.authentication.k8s.io/execextensionWhich issue(s) this PR fixes:
Fixes #2395
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: