Skip to content

Fix WireMock stub matching in KubernetesInformerCreatorTest #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 4 commits into from
Jan 23, 2026
+16 −2
Merged

Fix WireMock stub matching in KubernetesInformerCreatorTest #4543

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec58fa1
Initial plan
Copilot Jan 22, 2026
14926d1
Fix flaky KubernetesInformerCreatorTest by adding synchronization delay
Copilot Jan 22, 2026
ed95d69
Replace Thread.sleep with Awaitility for more robust synchronization
Copilot Jan 22, 2026
a91e044
Fix WireMock stub matching by adding priorities and Content-Type headers
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions ...t/java/io/kubernetes/client/spring/extended/controller/KubernetesInformerCreatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,11 @@ void informerInjection() throws InterruptedException {
get(urlPathEqualTo("/api/v1/pods"))
.withPostServeAction("semaphore", getParams)
.withQueryParam("watch", equalTo("false"))
.atPriority(1)
.willReturn(
aResponse()
.withStatus(200)
.withHeader("Content-Type", "application/json")
.withBody(
JSON.serialize(
new V1PodList()
Expand All @@ -137,15 +139,22 @@ void informerInjection() throws InterruptedException {
get(urlPathEqualTo("/api/v1/pods"))
.withPostServeAction("semaphore", watchParams)
.withQueryParam("watch", equalTo("true"))
.willReturn(aResponse().withStatus(200).withBody("{}")));
.atPriority(2)
Copy link
Member

@yue9944882 yue9944882 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add .atPriority() to WireMock stubs to ensure proper matching order (priority 1 for watch=false, priority 2 for watch=true)

i like this idea!

.willReturn(
aResponse()
.withStatus(200)
.withHeader("Content-Type", "application/json")
.withBody("{}")));

apiServer.stubFor(
get(urlPathEqualTo("/api/v1/namespaces/default/configmaps"))
.withPostServeAction("semaphore", getParams)
.withQueryParam("watch", equalTo("false"))
.atPriority(1)
.willReturn(
aResponse()
.withStatus(200)
.withHeader("Content-Type", "application/json")
.withBody(
JSON.serialize(
new V1ConfigMapList()
Expand All @@ -155,7 +164,12 @@ void informerInjection() throws InterruptedException {
get(urlPathEqualTo("/api/v1/namespaces/default/configmaps"))
.withPostServeAction("semaphore", watchParams)
.withQueryParam("watch", equalTo("true"))
.willReturn(aResponse().withStatus(200).withBody("{}")));
.atPriority(2)
.willReturn(
aResponse()
.withStatus(200)
.withHeader("Content-Type", "application/json")
.withBody("{}")));

// These will be released for each web call above.
getCount.acquire(2);
Expand Down
Loading