Skip to content

Remove unused spring-boot dependency from spring module #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Remove unused spring-boot dependency from spring module #4533

Copilot wants to merge 3 commits into from
+0 −11

Conversation

Copy link
Contributor

Copilot AI commented Jan 21, 2026 •
edited
Loading

Ran mvn dependency:analyze to identify unused dependencies. Removed org.springframework.boot:spring-boot (compile scope) from spring/pom.xml as it's not referenced in source.

Changes

  • Removed org.springframework.boot:spring-boot from spring/pom.xml

Note on dependency:analyze false positives

The analysis flagged several other dependencies as unused, but these are false positives:

  • spring-boot-test - used via @SpringBootTest annotation (runtime reflection)
  • junit-jupiter-params - provides transitive junit-jupiter-api for @Test annotations
  • client-java-spring-integration - used by examples module
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove unused dependencies from pom.xml</issue_title>
<issue_description>I think there are a number of unused dependencies that for historical reasons are still in our POM files.

We should use something like mvn dependency:analyze to strip these out.
</issue_description>

Comments on the Issue (you are @copilot in this section)

@yue9944882 ``` [WARNING] Used undeclared dependencies found: [WARNING] org.springframework:spring-beans:jar:6.2.2:compile [WARNING] io.kubernetes:client-java-extended:jar:23.0.0-SNAPSHOT:compile [WARNING] com.google.code.gson:gson:jar:2.12.1:compile [WARNING] org.springframework:spring-core:jar:6.2.2:compile [WARNING] io.swagger:swagger-annotations:jar:1.6.15:compile [WARNING] org.slf4j:slf4j-api:jar:2.0.16:compile [WARNING] org.springframework.boot:spring-boot-autoconfigure:jar:3.4.2:compile [WARNING] org.jetbrains:annotations:jar:13.0:compile [WARNING] Unused declared dependencies found: [WARNING] io.kubernetes:client-java-spring-integration:jar:23.0.0-SNAPSHOT:compile [WARNING] org.springframework.boot:spring-boot:jar:3.4.2:compile [WARNING] org.junit.jupiter:junit-jupiter:jar:5.11.4:test [WARNING] org.springframework.boot:spring-boot-test:jar:3.4.2:test [WARNING] org.springframework:spring-test:jar:6.2.2:test 

Yea we're safe to remove these packages I think</body></comment_new>
<comment_new><author>@brendandburns</author><body>
@Rishabh-mikku feel free to send PRs. </body></comment_new>
</comments>

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2026
@brendandburns
Remove unused dependencies from spring and examples modules
ba33b82 
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2026
@brendandburns
Restore needed dependencies that were incorrectly removed
a1a4791 
Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused dependencies from pom.xml Remove unused spring-boot dependency from spring module Jan 21, 2026
Copilot AI requested a review from brendandburns January 21, 2026 21:44
@brendandburns
Copy link
Contributor

brendandburns commented Jan 22, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@brendandburns brendandburns

Copilot code review Copilot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused dependencies from pom.xml

3 participants

@brendandburns @k8s-ci-robot