Clarify the Performance section benchmarks directory mode - #161
Closed
stijnvanhulle wants to merge 1 commit into
Closed
Clarify the Performance section benchmarks directory mode#161stijnvanhulle wants to merge 1 commit into
stijnvanhulle wants to merge 1 commit into
Conversation
"writing to a fresh directory" read as just a clean output folder, not output.mode: 'directory' on every plugin. Spells that out and notes that switching to kubb's default file mode changes the numbers substantially, since it costs v5 more than v4, validated against a real run of both modes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xRkYw3bDucJ342j15p9yg
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
A reader flagged that a separate hey-api/orval benchmark (not published here) reported a ~2.6x v4-vs-v5 speedup on the same big spec where this page says "up to 5x," and asked whether the two numbers conflict.
They don't, but the migration guide's wording didn't make why obvious. "Both versions writing to a fresh directory" reads as just "a clean output folder," when the real point is that
scripts/benchmark/v4-vs-v5runs every plugin inoutput.mode: 'directory'(one file per schema/operation) on both v4 and v5. Validated by actually running both kubb v4 and v5 in both file mode and directory mode on the same fixtures: switching both to kubb's default file mode makes both versions slower, but costs v5 disproportionately more (2.5x slower in file mode vs. v4's 1.3x slower), which is most of the difference between the "up to 5x" here and a flatter, smaller number in file mode. This PR spells that out in the Performance section's intro paragraph instead of leaving the mode choice implicit.No numbers in the guide changed, this is a wording clarification.
✅ Checklist
Generated by Claude Code