Improve synonym loading - #1122
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
lonvia
force-pushed
the
improve-synonym-loading
branch
from
September 4, 2026 10:02
64f6530 to
add5ce7
Compare
Collaborator
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit add5ce7. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how synonyms are loaded when serving: instead of rewriting the entire analyser configuration only the filters with the synonyms are updated.
Leaving the remaining analyser configuration untouched means that we can introduce breaking changes into the configuration. Such changes will now only be effective for new installations while existing ones can keep the analysers that are compatible with their database.
The change is not completely backwards compatible because the new installation method expects the synonym filters to be always present in the search analysers while the old method would only install them, when needed. Enabling synonyms on databases imported before this change will only work, if synonyms had already been enabled. The good news is that you can easily do that by starting an older version of Photon with synonyms. There is an error message which explains the steps.
Closes #1070.