secureenclave: remove deprecated crypto APIs, bump to go 1.26.5 - #61
Merged
Conversation
brhoades
force-pushed
the
billy/bump-go-and-secureenclave
branch
from
July 24, 2026 21:24
a8b9698 to
f4077ec
Compare
brhoades
force-pushed
the
billy/bump-go-and-secureenclave
branch
6 times, most recently
from
July 24, 2026 21:52
edb841d to
2e9cc8e
Compare
Go 1.26 deprecates the X and Y fields and 1.25 added the new API that we needed to make it work.
brhoades
force-pushed
the
billy/bump-go-and-secureenclave
branch
from
July 27, 2026 18:05
2e9cc8e to
dc89305
Compare
brhoades
commented
Jul 27, 2026
Comment on lines
+160
to
+162
| // PublicKey.Bytes below panics on nil coordinates This is fully cargo culted: | ||
| // I don't know if this actually occurs in production use. | ||
| //nolint:staticcheck |
Contributor
Author
There was a problem hiding this comment.
I don't know if we need this. The comment here is true, but whether it can actually happen outside of a test? 🤷
Contributor
There was a problem hiding this comment.
I don't think I know the answer to this either. I don't believe I've seen the public key has nil XY coordinates error in logs before, and I'm not seeing it in an extremely cursory search of Cloud Log
brhoades
marked this pull request as ready for review
July 27, 2026 18:41
RebeccaMahany
approved these changes
Jul 27, 2026
Comment on lines
+160
to
+162
| // PublicKey.Bytes below panics on nil coordinates This is fully cargo culted: | ||
| // I don't know if this actually occurs in production use. | ||
| //nolint:staticcheck |
Contributor
There was a problem hiding this comment.
I don't think I know the answer to this either. I don't believe I've seen the public key has nil XY coordinates error in logs before, and I'm not seeing it in an extremely cursory search of Cloud Log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously noted that a few crypto APIs were deprecated, even back in #37 we added lint excludes. I don't believe there was a way around it at the time for ecdsa, though? Go 1.26 further deprecated the
ecdsa.PublicKeyfields forXandYafter 1.25 addedecdsa.ParseUncompressedPublicKey, per the changelog:I'm no cryptographer, but this looks like what's required to remove our deprecated usage, since we can now directly parse a public key from some bytes. It also ended up being a roadblock when upgrading actionlint.
Changes:
/pkg/secureenclave's to use the new APIs described above.TPM Error
I added documentation about openssl after running into this error on TPM tests:
Test Results
Running the secureenclave tests pass: