Suppress internal title-generation Slack notifications - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A single user prompt can trigger an internal Codex title-generation request that codex-notify posts as another Slack conversation. Suppress the complete known title-generation envelope and its subsequent response in Hook normal mode, and filter the corresponding events in both log-tail publishers before they enter delivery.
The classifier matches the full instruction envelope with whitespace normalization and a non-empty embedded prompt. Ordinary title requests, introduced/quoted instructions, and JSON responses with a
titlefield remain eligible for delivery. Hook suppression persists across invocations and resume events; the next regular prompt clears it. Existing threads are preserved, while startup/clear and explicit thread resets retain their behavior.Security and compatibility
Validation
bundle exec rake— 272 runs, 1,466 assertions, 0 failures, 0 errors, 0 skips; line coverage 96.07% (1,709/1,779).git diff --check— passed.Fixes #88